Repository navigation
node:http: emit 'pause' on req.socket once an unread body fills the IncomingMessage buffer - #34740
Merged
Merged
Claude / Claude Code Review
completed
Jul 20, 2026 in 24m 23s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/runtime/server/NodeHTTPResponse.rs:1354-1358 |
do_pause guard skips pause_socket(), defeating pausePipelineReads |
Annotations
Check failure on line 1358 in src/runtime/server/NodeHTTPResponse.rs
claude / Claude Code Review
do_pause guard skips pause_socket(), defeating pausePipelineReads
The new `body_read_state != Pending` guard returns before `self.pause_socket()` at :1366, so `pausePipelineReads` (`_http_server.ts:2506`, called at :941) — whose head response's `body_read_state` is always `None` or `Done` by the time a pipelined request is dispatched — now sets `socket._paused = true` in JS but never actually pauses the fd, defeating the write-side read gate. Move `pause_socket()` above the guard to mirror `do_resume`, which calls `resume_socket()` unconditionally at :1413 bef
Loading