Skip to content

test(valkey): allocate refused port instead of hardcoding 12345 #34412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 1 commit into from
Closed

test(valkey): allocate refused port instead of hardcoding 12345 #34412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions test/js/valkey/reliability/connection-failures.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { RedisClient } from "bun";
import { describe, expect, mock, test } from "bun:test";
import { beforeAll, describe, expect, mock, test } from "bun:test";
import net from "net";
import { DEFAULT_REDIS_OPTIONS, DEFAULT_REDIS_URL, delay, isEnabled } from "../test-utils";

Expand All @@ -11,8 +11,17 @@ import { DEFAULT_REDIS_OPTIONS, DEFAULT_REDIS_URL, delay, isEnabled } from "../t
* - Error propagation
*/
describe.skipIf(!isEnabled)("Valkey: Connection Failures", () => {
// Use invalid port to force connection failure
const BAD_CONNECTION_URL = "redis://localhost:12345";
// A port with nothing listening so the connect is refused. bind(0)->close
// instead of a fixed port so an unrelated process occupying 12345 can't turn
// this into a protocol-parse failure ("Failed to read data (stack path)").
let BAD_CONNECTION_URL!: string;
beforeAll(async () => {
const server = net.createServer();
await new Promise<void>(resolve => server.listen(0, "127.0.0.1", resolve));
const port = (server.address() as net.AddressInfo).port;
await new Promise<void>(resolve => server.close(() => resolve()));
BAD_CONNECTION_URL = `redis://127.0.0.1:${port}`;
});

describe("Connection Failure Handling", () => {
test("should handle initial connection failure gracefully", async () => {
Expand Down
Loading