test: use tempDir in log-test.test.ts instead of hardcoded /tmp path

[robobun]

Failure

test/cli/run/log-test.test.ts went red on macOS aarch64 in build 73489:

EACCES: permission denied, open '/tmp/log-test-silent/.env'
    path: "/tmp/log-test-silent/.env",
 syscall: "open",
   errno: -13,
      at writeDirectoryTree (.../test/cli/run/log-test.test.ts:52:8)

Cause

Since it was added in 2023 this test has written its fixture to the hardcoded path /tmp/log-test-silent. The macOS CI hosts are persistent bare-metal machines that now run buildkite agents under more than one local user. When a run under one user leaves /tmp/log-test-silent behind with the default drwxr-xr-x mode, a subsequent run under a different user cannot unlink or rewrite its contents and the fs.writeFileSync call fails with EACCES. No source change triggered this; it is a latent non-hermetic test that surfaced when a second agent user started leaving the directory behind.

Fix

Use tempDir from harness so each run gets a unique, user-owned temporary directory that is removed via using on exit. The assertions and the files written (.env, bunfig.toml, index.ts) are unchanged, so the same .env-loading / logLevel code path is still exercised. The bespoke writeDirectoryTree helper is no longer needed and is removed.

Verification

bun bd test test/cli/run/log-test.test.ts
 2 pass
 0 fail

Confirmed on the affected host that /tmp contains entries owned by both ciadmin and administrator, which is what makes the fixed path unsafe.

[robobun]

^{Updated 8:31 PM PT - Jul 15th, 2026}

@robobun, your commit 2806e14 is building: #73599

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: afa8bed2-2512-42a1-a75b-47d6e50e13b6

📥 Commits

Reviewing files that changed from the base of the PR and between d29b050 and 2806e14.

📒 Files selected for processing (1)

• test/cli/run/log-test.test.ts

---

Walkthrough

Changes

The CLI logging tests now use tempDir for .env, bunfig.toml, and index.ts fixtures, replacing fixed /tmp paths and manual directory writing. Both tests pass the temporary directory as spawnSync’s working directory.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: switching the test to tempDir instead of a hardcoded /tmp path.
Description check	✅ Passed	The description covers the failure, cause, fix, and verification, though it does not use the repository's exact template headings.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[claude]

LGTM — mechanical test hermeticity fix.

What was reviewed:

• Confirmed tempDir from harness returns a disposable path wrapper (mkdtemp-based, unique per run) and String(dir) yields the cwd — matches the usage here.
• Assertions and fixture contents (.env, bunfig.toml, index.ts) are byte-identical to before; only the directory location changed.
• Removed writeDirectoryTree had no other callers in this file; fs/path imports are correctly dropped with it.

Extended reasoning...

Overview

This PR touches a single test file, test/cli/run/log-test.test.ts, replacing a hardcoded /tmp/log-test-silent fixture directory with the harness tempDir helper and a using declaration. The bespoke writeDirectoryTree helper (which swallowed errors and never cleaned up) is deleted along with its now-unused fs and path imports. The two test bodies otherwise keep identical fixture contents and identical assertions.

Security risks

None. Test-only change; no runtime, network, auth, or crypto surfaces are involved.

Level of scrutiny

Low. This is the canonical hermeticity pattern the repo's own guidelines prescribe (tempDir + using over ad-hoc /tmp paths), applied to fix a real CI flake caused by cross-user directory ownership on persistent macOS runners. I verified the tempDir implementation in test/harness.ts: it calls mkdtempSync under os.tmpdir() with a unique suffix, writes the file tree, and returns a DisposableString whose [Symbol.dispose] recursively removes the directory — so using dir = tempDir(...) and cwd: String(dir) behave exactly as needed here.

Other factors

The PR description shows the tests still pass (2 pass, 0 fail) under the debug build. The removed helper had no other call sites in the file, and the change follows the exact idiom used across dozens of other tests in the suite. No prior reviews or outstanding comments on the PR.