Repository navigation
resolver: take entries_mutex in entries_at before the in-place DirEntry rewrite - #34271
Merged
Merged
Claude / Claude Code Review
completed
Jul 15, 2026 in 14m 13s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/filesystem_router.test.ts:843-858 |
Test workload increased ~40× within unchanged 60s timeout |
Annotations
Check warning on line 858 in test/js/bun/util/filesystem_router.test.ts
claude / Claude Code Review
Test workload increased ~40× within unchanged 60s timeout
The concurrency fixture now runs 161 `Bun.build()` calls (1 warm-up + 40×4) over 80 entrypoints plus 2000 `reload()`s — ~40× the prior workload — while the `60_000` timeout at line 877 is unchanged. The 80 entrypoints are trivial one-liners so this may well fit, but debug+ASAN (the alpine x64 target that motivated this fix) is where the margin is thinnest; worth confirming #73420's wall-clock or bumping to match the 180s precedent at `bun-build-api.test.ts:1439` which does 400 builds under a sim
Loading