Skip to content

test(proxy-stress): dial 127.0.0.1 for the test proxy's upstream instead of resolving 'localhost' #34049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 3 commits into from
Jul 13, 2026
Merged

test(proxy-stress): dial 127.0.0.1 for the test proxy's upstream instead of resolving 'localhost' #34049

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6dcaac
test(proxy-stress): dial 127.0.0.1 instead of 'localhost' for the pro…
robobun Jul 12, 2026
2c5ba23
tighten comment to 3 lines
robobun Jul 12, 2026
637f1dd
ci: retrigger
robobun Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/js/bun/http/proxy-stress-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ export async function createAdversarialProxy(opts: AdversarialProxyOptions = {})
// and getaddrinfo want the bare literal.
if (host.startsWith("[") && host.endsWith("]")) host = host.slice(1, -1);

// Origins bind 127.0.0.1 but advertise `localhost`; on darwin that
// resolves `::1` first, and v4/v6 ephemeral-port spaces are independent,
// so dial the bound address. IPv6-literal tests pass `[::1]` explicitly.
if (host === "localhost") host = "127.0.0.1";

upstream = net.connect(port, host);
let clientEnded = false;
const endClient = () => {
Expand Down
Loading