Skip to content

test(proxy-stress-protocol): share proxy pair across concurrent tests #33987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Jul 12, 2026
Merged

test(proxy-stress-protocol): share proxy pair across concurrent tests #33987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions test/js/bun/http/proxy-stress-protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { once } from "node:events";
import net from "node:net";
import tls from "node:tls";
import {
AdversarialProxy,
cartesian,
clearProxyEnv,
createAdversarialOrigin,
Expand All @@ -22,11 +23,23 @@ import {
tlsCert,
} from "./proxy-stress-helpers";

// Concurrency note: 102 tests share one {http, https} proxy pair from
// beforeAll to avoid ephemeral-port reuse under test.concurrent's rolling
// listen(0) churn. Tests that inspect proxy.connections keep a dedicated
// proxy.
let savedEnv: Record<string, string | undefined>;
beforeAll(() => {
let sharedHttpProxy: AdversarialProxy;
let sharedHttpsProxy: AdversarialProxy;
const sharedProxy = (tls: boolean) => (tls ? sharedHttpsProxy : sharedHttpProxy);

beforeAll(async () => {
savedEnv = clearProxyEnv();
sharedHttpProxy = await createAdversarialProxy({ tls: false });
sharedHttpsProxy = await createAdversarialProxy({ tls: true });
});
afterAll(() => {
afterAll(async () => {
await sharedHttpProxy?.close();
await sharedHttpsProxy?.close();
restoreProxyEnv(savedEnv);
});

Expand Down Expand Up @@ -75,7 +88,7 @@ describe("early reply during upload", () => {
`${proxyTls ? "https" : "http"}-proxy → ${originTls ? "https" : "http"}-origin, ${status} after 1KB of a 1MB upload`,
async () => {
await using origin = await makeEarlyReplyOrigin(status, 1024, originTls);
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, {
method: "POST",
body: Buffer.alloc(1024 * 1024, "u"),
Expand Down Expand Up @@ -122,6 +135,7 @@ describe("multi-hop redirect through proxy", () => {
origins.push({ close: () => o.close(), url: o.url });
next = o.url;
}
// This test inspects proxy.connections, so it needs a dedicated proxy.
await using proxy = await createAdversarialProxy({ tls: proxyTls });
try {
const res = await fetch(next!, { proxy: proxy.url, keepalive: false, tls: laxTls });
Expand Down Expand Up @@ -160,7 +174,7 @@ describe("large response headers through tunnel", () => {
body: "big",
headers: { "X-Big": bigValue },
});
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, { proxy: proxy.url, keepalive: false, tls: laxTls });
expect(await res.text()).toBe("big");
expect(res.headers.get("x-big")).toBe(bigValue);
Expand All @@ -185,7 +199,7 @@ describe("large request headers through tunnel", () => {
async () => {
const bigValue = Buffer.alloc(size, "Q").toString("latin1");
await using origin = await createAdversarialOrigin({ tls: originTls, body: "ok" });
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, {
proxy: proxy.url,
keepalive: false,
Expand Down Expand Up @@ -234,7 +248,7 @@ describe("1xx through tunnel", () => {
`${proxyTls ? "https" : "http"}-proxy → ${originTls ? "https" : "http"}-origin, ${info} then 200`,
async () => {
await using origin = await make1xxOrigin(originTls, info);
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, {
method: "POST",
body: "x",
Expand Down Expand Up @@ -267,6 +281,7 @@ describe.skipIf(!isIPv6())("IPv6 literal origin through proxy", () => {
tls: originTls ? tlsCert : undefined,
fetch: () => new Response("v6"),
});
// This test inspects proxy.connections, so it needs a dedicated proxy.
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const scheme = originTls ? "https" : "http";
const res = await fetch(`${scheme}://[::1]:${origin.port}/`, {
Expand Down Expand Up @@ -300,6 +315,7 @@ describe("many proxy.headers", () => {
`${proxyTls ? "https" : "http"}-proxy → ${originTls ? "https" : "http"}-origin, ${count} proxy headers`,
async () => {
await using origin = await createAdversarialOrigin({ tls: originTls, body: "ok" });
// This test inspects proxy.connections, so it needs a dedicated proxy.
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const headers: Record<string, string> = {};
for (let i = 0; i < count; i++) headers[`X-Proxy-${i}`] = `v${i}`;
Expand Down Expand Up @@ -383,7 +399,7 @@ describe("HTTP/1.0 origin through tunnel", () => {
`${proxyTls ? "https" : "http"}-proxy → ${originTls ? "https" : "http"}-origin HTTP/1.0`,
async () => {
await using origin = await makeHttp10Origin(originTls);
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, { proxy: proxy.url, keepalive: false, tls: laxTls });
expect(await res.text()).toBe("old-school");
expect(res.status).toBe(200);
Expand All @@ -407,6 +423,7 @@ describe('redirect: "manual" through proxy', () => {
async () => {
await using target = await createAdversarialOrigin({ tls: originTls, body: "should-not-reach" });
await using origin = await createAdversarialOrigin({ tls: originTls, redirectTo: target.url });
// This test inspects proxy.connections, so it needs a dedicated proxy.
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const res = await fetch(origin.url, {
proxy: proxy.url,
Expand Down Expand Up @@ -439,6 +456,7 @@ describe('redirect: "error" through proxy', () => {
tls: originTls,
redirectTo: "http://never-reached.invalid/",
});
// This test inspects proxy.connections, so it needs a dedicated proxy.
await using proxy = await createAdversarialProxy({ tls: proxyTls });
await expect(
fetch(origin.url, {
Expand Down Expand Up @@ -473,7 +491,7 @@ describe("response body consumers through tunnel", () => {
body: payload,
headers: consumer === "json" ? { "Content-Type": "application/json" } : {},
});
await using proxy = await createAdversarialProxy({ tls: proxyTls });
const proxy = sharedProxy(proxyTls);
const res = await fetch(origin.url, { proxy: proxy.url, keepalive: false, tls: laxTls });
expect(res.status).toBe(200);
switch (consumer) {
Expand Down
Loading