Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughChangessetSystemTime type contract
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@alii - Buildkite has been pending since July 10, and CodeRabbit reported no actionable issues. Could you approve or restart the CI run, or route this to the right reviewer? I can make any requested changes. Thanks! |
|
Hi maintainers, this PR has been open for over two weeks. When you have a moment, I would appreciate a review. Thank you. |
|
Triage note: this is not on main yet (checked at f426a8e), the branch still merges cleanly, and One heads up: #32333, #32335, #32455 and #33923 all append to the end of Thanks for the fix and for the patience. |
What changed
jest.setSystemTime()as returning thejestobject, matching the runtime.Why
The native host function returns its receiver, but the declaration reported
void. This prevented typed fluent usage even though it already works at runtime.Verification
jest.setSystemTime() === jest