cookie: update remaining cookie-map Expires assertions to IMF-fixdate - #33425
Conversation
|
Updated 3:05 AM PT - Jul 6th, 2026
@Jarred-Sumner, your commit be69aa8 is building: |
There was a problem hiding this comment.
LGTM — test-only assertion update to match the IMF-fixdate format already used elsewhere in this file.
Extended reasoning...
Overview
This PR updates four expected string literals in test/js/bun/cookie/cookie-map.test.ts from the old Fri, 1 Jan 1970 00:00:00 -0000 format to the IMF-fixdate Thu, 01 Jan 1970 00:00:00 GMT format. These are the assertions in the delete with prefixed cookie names describe block that were added in #33072 just before #32926 changed the serialization format, so they were left behind with the stale spelling. No production code is touched.
Security risks
None. This is a test-only change that adjusts expected string values in assertions.
Level of scrutiny
Low. The change is purely mechanical: the new expected string exactly matches the format already asserted elsewhere in the very same file (e.g. the CookieMap methods work test uses Expires=Thu, 01 Jan 1970 00:00:00 GMT in its inline snapshot). Jan 1, 1970 is indeed a Thursday, and IMF-fixdate is the RFC 7231 canonical form. The PR description states the file goes from 30/3 to 33/0 with this change.
Other factors
No bugs were flagged by the bug-hunting system. No outstanding reviewer comments. The diff is 4 lines of string literal updates in a single test file with clear intent and internal consistency.
|
This PR may be a duplicate of:
🤖 Generated with Claude Code |
#32926 changed
Bun.Cookie'sExpiresserialization to an IMF-fixdate (Thu, 01 Jan 1970 00:00:00 GMT) and updated the assertions it touched, but the expiring-delete assertions added in #33072 the day before still expect the oldFri, 1 Jan 1970 00:00:00 -0000spelling, sotest/js/bun/cookie/cookie-map.test.tscurrently fails onmain(3 tests).This updates those four remaining strings to the format #32926 established. Test-only.
bun bd test test/js/bun/cookie/cookie-map.test.ts: 33 pass / 0 fail (30/3 before).