Skip to content

cookie: update remaining cookie-map Expires assertions to IMF-fixdate - #33425

Merged
Jarred-Sumner merged 1 commit into
mainfrom
claude/cookie-map-imf-fixdate
Jul 6, 2026
Merged

Jarred-Sumner merged 1 commit into
mainfrom
claude/cookie-map-imf-fixdate

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

#32926 changed Bun.Cookie's Expires serialization to an IMF-fixdate (Thu, 01 Jan 1970 00:00:00 GMT) and updated the assertions it touched, but the expiring-delete assertions added in #33072 the day before still expect the old Fri, 1 Jan 1970 00:00:00 -0000 spelling, so test/js/bun/cookie/cookie-map.test.ts currently fails on main (3 tests).

This updates those four remaining strings to the format #32926 established. Test-only.

  • bun bd test test/js/bun/cookie/cookie-map.test.ts: 33 pass / 0 fail (30/3 before).

#32926 switched Bun.Cookie's Expires serialization to an IMF-fixdate but
missed the expiring-delete assertions added in #33072, leaving
cookie-map.test.ts failing on main.
@robobun

robobun commented Jul 6, 2026 •

Copy link
Copy Markdown
Collaborator
Updated 3:05 AM PT - Jul 6th, 2026

@Jarred-Sumner, your commit be69aa8 is building: #68799

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — test-only assertion update to match the IMF-fixdate format already used elsewhere in this file.

Extended reasoning...

Overview

This PR updates four expected string literals in test/js/bun/cookie/cookie-map.test.ts from the old Fri, 1 Jan 1970 00:00:00 -0000 format to the IMF-fixdate Thu, 01 Jan 1970 00:00:00 GMT format. These are the assertions in the delete with prefixed cookie names describe block that were added in #33072 just before #32926 changed the serialization format, so they were left behind with the stale spelling. No production code is touched.

Security risks

None. This is a test-only change that adjusts expected string values in assertions.

Level of scrutiny

Low. The change is purely mechanical: the new expected string exactly matches the format already asserted elsewhere in the very same file (e.g. the CookieMap methods work test uses Expires=Thu, 01 Jan 1970 00:00:00 GMT in its inline snapshot). Jan 1, 1970 is indeed a Thursday, and IMF-fixdate is the RFC 7231 canonical form. The PR description states the file goes from 30/3 to 33/0 with this change.

Other factors

No bugs were flagged by the bug-hunting system. No outstanding reviewer comments. The diff is 4 lines of string literal updates in a single test file with clear intent and internal consistency.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This PR may be a duplicate of:

  1. test: update cookie deletion expectations to IMF-fixdate #33424 - Also updates the same 4 cookie-map test assertions from the old Expires format to IMF-fixdate, with an identical diff

🤖 Generated with Claude Code

@Jarred-Sumner
Jarred-Sumner merged commit 48ff9eb into main Jul 6, 2026
77 of 79 checks passed
@Jarred-Sumner
Jarred-Sumner deleted the claude/cookie-map-imf-fixdate branch July 6, 2026 10:30
This was referenced Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants