Skip to content

Bun.build: stop blocking the event loop on an async plugin setup() #33271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 5 commits into from
Closed

Bun.build: stop blocking the event loop on an async plugin setup() #33271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64efcaf
Bun.build: stop blocking the event loop on an async plugin setup()
robobun Jul 2, 2026
a3c00d1
[autofix.ci] apply automated fixes
autofix-ci[bot] Jul 2, 2026
037d3fa
Bun.build: GC-root the suspended setup() promise until .then attaches
robobun Jul 2, 2026
14ca1fc
test: add Promise.race escape coverage for never-settling setup()
robobun Jul 26, 2026
112f49c
JSBundler: trim added doc comments to one line each
robobun Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/jsc/bindings/ZigGlobalObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4080,6 +4080,10 @@ GlobalObject::PromiseFunctions GlobalObject::promiseHandlerID(Zig::FFIFunction h
return GlobalObject::PromiseFunctions::Bun__HTTPRequestContextDebugH3__onResolve;
} else if (handler == Bun__HTTPRequestContextDebugH3__onResolveStream) {
return GlobalObject::PromiseFunctions::Bun__HTTPRequestContextDebugH3__onResolveStream;
} else if (handler == Bun__JSBundler__onResolvePluginSetup) {
return GlobalObject::PromiseFunctions::Bun__JSBundler__onResolvePluginSetup;
} else if (handler == Bun__JSBundler__onRejectPluginSetup) {
return GlobalObject::PromiseFunctions::Bun__JSBundler__onRejectPluginSetup;
} else {
RELEASE_ASSERT_NOT_REACHED();
}
Expand Down
4 changes: 3 additions & 1 deletion src/jsc/bindings/ZigGlobalObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,10 @@ class GlobalObject : public Bun::GlobalScope {
Bun__HTTPRequestContextDebugH3__onRejectStream,
Bun__HTTPRequestContextDebugH3__onResolve,
Bun__HTTPRequestContextDebugH3__onResolveStream,
Bun__JSBundler__onResolvePluginSetup,
Bun__JSBundler__onRejectPluginSetup,
};
static constexpr size_t promiseFunctionsSize = 42;
static constexpr size_t promiseFunctionsSize = 44;

static PromiseFunctions promiseHandlerID(SYSV_ABI EncodedJSValue (*handler)(JSC::JSGlobalObject* arg0, JSC::CallFrame* arg1));

Expand Down
3 changes: 3 additions & 0 deletions src/jsc/bindings/headers.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading