Skip to content

Quarantine test-net-connect-memleak on linux-x64-musl #33045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 2 commits into from
Closed

Quarantine test-net-connect-memleak on linux-x64-musl #33045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e3571
Quarantine test-net-connect-memleak on linux-x64-musl
robobun Jun 29, 2026
3e810cf
ci: retrigger
robobun Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions test/expectations.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,23 @@ test/cli/run/run-crash-handler.test.ts [ FAIL ] # automatic crash reporter > seg
# the spawned child needs process.binding('inspector'), which is not implemented
test/js/node/test/parallel/test-inspector-enabled.js [ FAIL ]

# Verbatim node v26.3.0 test asserting a FinalizationRegistry callback fires
# Verbatim node v26.3.0 tests asserting a FinalizationRegistry callback fires
# within ONE globalThis.gc() + ONE setImmediate after the connect callback's
# closure is unreferenced. The FinalizationRegistry spec gives no timing
# guarantee for cleanup callbacks; JSC schedules them via DeferredWorkTimer
# with no defined ordering relative to the immediate queue. The connect
# listener IS removed (verified: listenerCount("secureConnect") === 0 in
# done()) and the object IS collected (test passes 70/70 on darwin and
# glibc Linux); on alpine x64 the FR callback delivery slips past the single
# setImmediate after this PR's added module loads at process startup shift
# the heap layout. The robust fix is gcUntil() rather than a single tick,
# but the file is a verbatim upstream port. Quarantined on the failing
# linux-x64-musl matrix only; still runs everywhere else (build 63145:
# alpine 3.23 x64 + x64-baseline only).
# listener IS removed (verified listenerCount 0 in done(): "secureConnect"
# for tls, "connect" for net) and the object IS collected (both pass on
# darwin and glibc Linux); on alpine x64 the FR callback delivery slips past
# the single setImmediate, so the assertion reds the lane on ~half of PR
# builds. The robust fix is gcUntil() rather than a single tick, but these
# are verbatim upstream ports we do not edit. Quarantined on the failing
# linux-x64-musl matrix only (alpine 3.23 x64 + x64-baseline); still runs
# everywhere else. Both twins share the identical onGC + gc() + setImmediate
# pattern: the tls one was quarantined first (build 63145), the net one has
# been failing intermittently since ~2026-06-28 (e.g. builds 66653, 66657).
[ LINUX-X64-MUSL ] test/js/node/test/parallel/test-tls-connect-memleak.js [ FLAKY ] # JSC FinalizationRegistry callback delivery vs setImmediate timing on musl x64
[ LINUX-X64-MUSL ] test/js/node/test/parallel/test-net-connect-memleak.js [ FLAKY ] # JSC FinalizationRegistry callback delivery vs setImmediate timing on musl x64

# Vendored node v26.3.0 stream tests blocked on missing native subsystems (see PR #31826)
test/js/node/test/parallel/test-stream-pipeline.js [ SKIP ] # block at L271 hangs: pipeline(rs, req) writes 11x'hello' raw after a never-ended GET's \r\n\r\n; node's llhttp rejects lowercase 'h' as a method char (HPE_INVALID_METHOD -> clientError -> 400+close -> req 'close' -> pipeline callback fires), but bun's uWS HttpParser buffers any incomplete run of valid tchars waiting for the request-line, so the connection stays open and the callback never fires. Pre-existing server-parser leniency; needs uWS HttpParser to reject non-uppercase method bytes like llhttp.
Expand Down
Loading