Further landing accessibility improvements#330
Merged
Conversation
Contributor
Author
|
Also, this is more of an SEO thing, but according to lighthouse the page is also missing a |
michellbrito
reviewed
Jul 8, 2022
Contributor
|
Lighthouse report
|
Contributor
Author
|
Visual Changes - Only thing changed are these chip colors for better contrast.
|
Contributor
Author
|
Also: it's worth noting that the 98 in the "after" LH score is likely caused by the comment color used in the site's syntax theme. Since shiki renders these on build through inline styles, and it's pretty low priority I don't think i'll touch that in this PR.
|
Contributor
|
@Tropix126 nah, it's that pink tag. I think we can ignore WCAG 2.0 lies on that one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the following potential accessibility pitfalls on the site:
lang="en"to<html>which helps screenreaders correctly identify the site's language.<ul>element to the navbar so their children<li>s have valid semantic meaning.<li>elements from benchmarks tabbar as ARIA requires thetablistrole's direct children to havetabitemroles, making them redundant and potentially harmful to screenreaders. This also inadvertently fixes a regression with some missing selection styling introduced by fix a11y issues on landing #225.unselectableclass repetition from CodeBox and just slaps auser-select: none;on it's base element to simplify things CSS-wise.removeshides the second potential instance.)