Skip to content

test: stop asserting an OCSP URI on the live bun.sh certificate #32789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Jun 26, 2026
Merged

test: stop asserting an OCSP URI on the live bun.sh certificate #32789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/js/node/tls/node-tls-connect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,11 @@ for (const { name, connect } of tests) {
expect(cert.subject.CN).toBe("bun.sh");
expect(cert.subjectaltname).toContain("DNS:bun.sh");
expect(cert.infoAccess).toBeDefined();
// we just check the types this can change over time
// The live cert's AIA contents change on reissue (public CAs stopped
// including OCSP URIs in 2025), so only assert the stable CA Issuers
// entry here; exact parsing is covered by the fixed-fixture x509 tests.
const infoAccess = cert.infoAccess as NodeJS.Dict<string[]>;
expect(infoAccess["OCSP - URI"]).toBeDefined();
expect(infoAccess["CA Issuers - URI"]).toBeDefined();
expect(infoAccess["CA Issuers - URI"]).toEqual(expect.arrayContaining([expect.stringMatching(/^https?:\/\//)]));
expect(cert.ca).toBeFalse();
expect(cert.bits).toBeInteger();
// These can change:
Expand Down
Loading