Skip to content

node:http2: apply SETTINGS_HEADER_TABLE_SIZE to the HPACK decoder and encoder - #32775

Closed
robobun wants to merge 5 commits into
mainfrom
farm/f43b8cc2/h2-decoder-header-table-size
Closed

robobun wants to merge 5 commits into
mainfrom
farm/f43b8cc2/h2-decoder-header-table-size

ci: retrigger

223e492
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 9, 2026 in 20m 0s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/runtime/api/bun/h2_frame_parser.rs:5618-5626 Single-frame duplicate HEADER_TABLE_SIZE entries bypass §4.2 interval-minimum handling

Annotations

Check warning on line 5626 in src/runtime/api/bun/h2_frame_parser.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Single-frame duplicate HEADER_TABLE_SIZE entries bypass §4.2 interval-minimum handling

Nit: the `pending_enc_min` interval-minimum tracking closes the RFC 7541 §4.2 gap for two *separate* SETTINGS frames (`[HTS=0]` then `[HTS=4096]`), but not for a *single* SETTINGS frame carrying duplicate entries (`[HTS=0, HTS=4096]`) — `handle_settings` applies entries cumulatively then invokes `on_remote_settings` once with the final snapshot (4096), so `queue_encoder_capacity(4096)` early-returns and the transient 0 is never seen. Exotic (no mainstream client emits duplicate HTS in one frame;