Skip to content

fetch: do not touch JSCells in the Response Weak finalizer during GC sweep - #32729

Merged
Jarred-Sumner merged 3 commits into
mainfrom
farm/ea9d7a26/fetch-weak-finalizer-sweep
Jun 26, 2026
Merged

Jarred-Sumner merged 3 commits into
mainfrom
farm/ea9d7a26/fetch-weak-finalizer-sweep

ci: retrigger

0889b05
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jun 26, 2026 in 21m 3s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing src/runtime/webcore/fetch/FetchTasklet.rs:2469-2476 Pre-existing: 'Scenario 2b' comment label is inverted

Annotations

Check notice on line 2476 in src/runtime/webcore/fetch/FetchTasklet.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Pre-existing: 'Scenario 2b' comment label is inverted

Pre-existing nit (not introduced by this PR): this comment should read `// Scenario 2a.` — per the list at lines 2454-2456, 2b is "have a promise → keep loading", but this branch fires when `promise.is_empty_or_undefined_or_null()` and *ignores* the body, i.e. 2a. The PR only touched the adjacent argument, so feel free to fix as a drive-by or leave for later.