inspector: interrupt a busy JS loop so Debugger.pause is serviced - #32549
Open
robobun wants to merge 10 commits into
Open
inspector: interrupt a busy JS loop so Debugger.pause is serviced#32549robobun wants to merge 10 commits into
robobun wants to merge 10 commits into
Claude / Claude Code Review
completed
Jun 21, 2026 in 22m 19s
Code review found 1 important issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | test/regression/issue/32548.test.ts:14 |
skipIf(!isDebug) gate yields zero CI coverage of the fix |
Annotations
Check failure on line 14 in test/regression/issue/32548.test.ts
claude / Claude Code Review
skipIf(!isDebug) gate yields zero CI coverage of the fix
Commit 21d037cd swapped `skipIf(!isASAN)` for `skipIf(!isDebug)` in response to #3447802202, but `isDebug` (`Bun.version.includes("debug")`) is false on every default CI lane — `.buildkite/ci.mjs`'s test matrix has only release and `profile: "asan"` entries, with "debug" available solely as a manual opt-in. So the PR's only regression test now runs on **zero** CI lanes (down from one), leaving the fix effectively untested per CLAUDE.md ("Every behavioral change ships an automated test in the sam
Loading