Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/harness.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,11 @@ export async function describeWithContainer(
_port = info.ports[servicePort];
console.log(`Container ready via docker-compose: ${image} at ${_host}:${_port}`);
readyResolver!();
});
// Cold container start is bounded by `compose up --wait-timeout 60` plus
// a `compose build` step; the default 5s hook timeout fires first and the
// runner's auto-killer then SIGTERMs the in-flight compose subprocesses,
// surfacing as bogus `Failed to start service X: ... Creating` errors.
}, 120_000);
Comment thread
coderabbitai[bot] marked this conversation as resolved.

fn(containerDescriptor);
});
Expand Down
5 changes: 4 additions & 1 deletion test/js/valkey/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,10 @@ if (isEnabled) {
// if (!context.initialized) {
// console.warn("Test initialization failed - tests may be skipped");
// }
});
// Cold container start is bounded by `compose up --wait-timeout 60` plus
// a `compose build` step; the default 5s hook timeout fires long before
// that on a cold cache.
}, 120_000);
}

if (isEnabled) {
Expand Down
5 changes: 4 additions & 1 deletion test/js/valkey/valkey.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ for (const connectionType of [ConnectionType.TLS, ConnectionType.TCP]) {
if (!ctx.redis) {
ctx.redis = createClient(connectionType);
}
});
// setupDockerContainer() may cold-start the redis_unified container
// (compose up --wait-timeout 60); shielded by the file-level beforeAll's
// cached promise once that has run, but match its timeout for safety.
}, 120_000);

beforeEach(async () => {
if (!ctx.redis) {
Expand Down
5 changes: 4 additions & 1 deletion test/js/web/websocket/autobahn.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ describe.skipIf(!isDockerEnabled())("autobahn", () => {
wsOptions = process.env.BUN_AUTOBAHN_HOST_HEADER
? { headers: { Host: process.env.BUN_AUTOBAHN_HOST_HEADER } }
: undefined;
});
// Cold container start is bounded by `compose up --wait-timeout 60` plus
// a `compose build` step; the default 5s hook timeout fires long before
// that on a cold cache.
}, 120_000);

function getCaseStatus(testID: number) {
return new Promise((resolve, reject) => {
Expand Down
Loading