Skip to content

test: await expectMaxObjectTypeCount in the named-pipe leak check #32093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: await expectMaxObjectTypeCount in the named-pipe leak check #32093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c945852
test: await expectMaxObjectTypeCount in the named-pipe leak check
robobun Jun 11, 2026
6ed3ec1
ci: retrigger
robobun Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/js/node/net/node-net.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ it.if(isWindows)(
}

const batch = [];
const before = heapStats().objectTypeCounts.TLSSocket || 0;
const before = heapStats().objectTypeCounts.TCPSocket || 0;
for (let i = 0; i < 100; i++) {
batch.push(test(`\\\\.\\pipe\\test\\${randomUUID()}`));
batch.push(test(`\\\\?\\pipe\\test\\${randomUUID()}`));
Expand All @@ -853,7 +853,11 @@ it.if(isWindows)(
}
}
await Promise.all(batch);
expectMaxObjectTypeCount(expect, "TCPSocket", before);
// Allow a few stragglers: server.close() can resolve before the last
// accepted pipe socket's finalizer runs (same margin as
// node-tls-namedpipes.test.ts). A leak on this path would leave hundreds
// of sockets behind.
await expectMaxObjectTypeCount(expect, "TCPSocket", before + 10, 5000);
},
20_000,
);
Expand Down
Loading