-
Notifications
You must be signed in to change notification settings - Fork 4.7k
DEBUG: instrument http2 pipe timeout on darwin (do not merge) #32002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
b9c81b2
Report Node.js 26.3.0 (V8 14.6.202.34, ABI 147)
Jarred-Sumner a914c27
webstreams: settle pending BYOB reads when the reader is cancelled
Jarred-Sumner f950dce
node:stream, node:http: sync behavioral changes from Node 24.x to 26.x
Jarred-Sumner 22df8d4
[autofix.ci] apply automated fixes
autofix-ci[bot] 4decf80
Bump bootstrap image versions for Node.js 26.3.0 [build images]
Jarred-Sumner 73d4931
Node 26: restore native upgrade pieces (V8 14.6 shim, ABI 147) [build…
Jarred-Sumner 1474e49
http, streams: review fixes for the Node 26 sync [build images]
Jarred-Sumner 40bf490
bootstrap: keep the xwin cache on the same filesystem as the splat ou…
Jarred-Sumner 2bffbf7
[autofix.ci] apply automated fixes
autofix-ci[bot] 1646e94
Rebuild CI images for the Node 26.3.0 toolchain [build images]
Jarred-Sumner 4e86a1c
bootstrap: install musl Node.js from unofficial-builds.nodejs.org [bu…
Jarred-Sumner af1bac6
Fix node-gyp on Windows and stale cipher stream tests for Node 26 [bu…
Jarred-Sumner f8aec41
streams: let destroyed-flagged readables still flush to piped destina…
Jarred-Sumner e194e98
next-pages tests: skip puppeteer browser download when it can't be us…
Jarred-Sumner 3771d7a
Address review feedback: escape-slot lifetime, set-cookie consistency…
Jarred-Sumner 71e4ae0
http2: destroy streams on socket close; never RST a never-started req…
Jarred-Sumner f8c00f1
v8: restore HandleScopeData when a Bun handle scope pops [build images]
Jarred-Sumner 694c0ff
http2: validate options.signal before the pre-aborted fast path
Jarred-Sumner 2b5e85b
packer: switch the windows-x64 bake VM to Standard_D4as_v7
Jarred-Sumner e256d3d
bootstrap: bump image versions past stale v35 tags [build images]
Jarred-Sumner abd2649
http2: send GOAWAY on graceful close(); run test node-gyp builds unde…
Jarred-Sumner 5f5c532
v8 tests: run the node-side fixture build under bun too [build images]
Jarred-Sumner 537a29c
process.config: report clang=1 on macOS; surface exit codes in v8 har…
Jarred-Sumner 326cf3b
complex-workspace test: skip lifecycle scripts on Windows [build images]
Jarred-Sumner 5738163
bootstrap: install Chrome on x64 apt images; recognize google-chrome …
Jarred-Sumner b3f5e61
symbols.def: export Value::IsArray/IsBigInt/IsInt32/IsMap [build images]
Jarred-Sumner a6bc225
v8 fixture: add stderr step markers to the tests that die on Windows …
Jarred-Sumner 0a144f1
v8: export the V8_INLINE members MSVC debug builds import [build images]
Jarred-Sumner ae74b31
http2: lastStreamId <= 0 in goaway means the actual last stream [buil…
Jarred-Sumner 83a4ad0
Merge main into Node 26 upgrade branch
cirospaciari c512404
tests: tolerate machines whose Node or toolchain lags the reported AB…
cirospaciari 3693c99
ci: rebuild bootstrap images for the Node 26 toolchain [build images]
cirospaciari a3b9f18
test harness: download the ABI-matching node with curl, cache in ~/.c…
cirospaciari c4fe0c9
DEBUG: instrument http2 serverrequest-pipe timeout on darwin-aarch64
cirospaciari ee0abaf
DEBUG: drop binary-size step on trimmed pipeline
cirospaciari 0822855
DEBUG: bake host image for trimmed pipeline [build images]
cirospaciari 55adb92
DEBUG: include linux-aarch64 platforms so host images get baked [buil…
cirospaciari 7c3f545
DEBUG: loop the instrumented pipe scenario with 3-way concurrency
cirospaciari 1bfde82
DEBUG: rerun with images [build images]
cirospaciari b3fda1e
DEBUG: run full http2 family; instrument the real pipe test in place …
cirospaciari f9c4521
DEBUG: instrument server socket/session lifecycle [build images]
cirospaciari 886a1b6
http2: destroy the server session when its socket closes [build images]
cirospaciari a33c1fc
DEBUG: revert maybeReadMore kReading guard [build images]
cirospaciari 59a4a87
DEBUG: capture client socket state; add plain-net EOF probe [build im…
cirospaciari d3f2ae4
DEBUG: stderr prints in socket teardown paths [build images]
cirospaciari 52d77a1
[autofix.ci] apply automated fixes
autofix-ci[bot] 971e41c
DEBUG: rerun after autofix [build images]
cirospaciari 87ae012
DEBUG: null-safe teardown prints [build images]
cirospaciari 3f89df4
[autofix.ci] apply automated fixes
autofix-ci[bot] c6efd6f
DEBUG: rerun after autofix [build images]
cirospaciari 68f2d55
DEBUG: pause/resume + native on_data prints [build images]
cirospaciari 63a86ef
DEBUG: per-poll and per-recv prints in loop.c [build images]
cirospaciari d2767d3
DEBUG: bake host image for trimmed pipeline [build images]
cirospaciari aac6c95
DEBUG: rerun with images [build images]
cirospaciari c4be3b1
DEBUG: rerun after autofix [build images]
cirospaciari 469c227
DEBUG: rerun after autofix [build images]
cirospaciari ee8547c
DEBUG: stream end-of-life prints [build images]
cirospaciari d653ca4
[autofix.ci] apply automated fixes
autofix-ci[bot] eaa7f1e
DEBUG: rerun after autofix [build images]
cirospaciari bc0c717
DEBUG: strip prints; fix headers-only END_STREAM stream leak [build i…
cirospaciari 71b8b76
DEBUG: drop leftover include [build images]
cirospaciari fb91e22
DEBUG: strip JS prints [build images]
cirospaciari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the nearby Node version comment to match the new pin.
After switching to
pkgs.nodejs_26, the package-list comment still says “version pinned to 24”, which is now misleading.Suggested patch
🤖 Prompt for AI Agents