Upgrade WebKit to 6d586e29 - #31724
Merged
Merged
Claude / Claude Code Review
completed
Jun 2, 2026 in 16m 11s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/deps/webkit.ts:10 |
Stale windows-baseline LTO gate after WebKit bump adds -baseline-lto variant |
Annotations
Check warning on line 10 in scripts/build/deps/webkit.ts
claude / Claude Code Review
Stale windows-baseline LTO gate after WebKit bump adds -baseline-lto variant
This bump includes [`c787a5a7`](https://github.com/oven-sh/WebKit/commit/c787a5a7ce04046e9f70963aac46e7848082e218) ("windows cross: add the amd64-baseline ThinLTO variant"), so `bun-webkit-windows-amd64-baseline-lto.tar.gz` now exists in the pinned release. However, `scripts/build/config.ts:769` still hard-forces `lto = false` for `(windows && baseline)`, and the comments at `config.ts:746-748` and `config.ts:767-768` still claim the pinned `WEBKIT_VERSION` lacks/predates the `-baseline-lto` var
Loading