yaml: clear remaining 3 non-cyclic test.todo entries (BOM strip, 2-anchor e-node key, flow cmi gap) - #31569
Merged
Merged
Claude / Claude Code Review
completed
May 29, 2026 in 32m 23s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/api/YAMLObject.rs:903-910 |
Stale 'Parser rule:' inline comments in string_is_number body |
Annotations
Check warning on line 910 in src/runtime/api/YAMLObject.rs
claude / Claude Code Review
Stale 'Parser rule:' inline comments in string_is_number body
Nit: the doc-comment update (per #3326791810) dropped the stale embedded-`+`/`-` clauses, but the two inline `// Parser rule:` comments in the body at :998 and :1004 still cite the pre-PR rules ("'+' accepted unless we're in hex base", "at most one '-' after the leading sign") — the parser's `is_core_schema_number` gate now rejects any embedded `+`/`-`, so these contradict the freshly-updated header. No functional impact (over-quoting is safe); just drop the `Parser rule:` prefix or reword to e.
Loading