paths: delete unused Path::move_ no-op#31551
Conversation
|
Warning Review limit reached
More reviews will be available in 2 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
|
Updated 11:05 PM PT - May 28th, 2026
❌ @dylan-conway, your commit 87637b2 has 1 failures in
🧪 To try this PR locally: bunx bun-pr 31551That installs a local version of the PR into your bun-31551 --bun |
There was a problem hiding this comment.
LGTM — trivial dead-code removal of an identity no-op.
Extended reasoning...
Overview
This PR deletes a single 4-line method, Path::move_, from src/paths/Path.rs. The method body was self — a pure identity function that existed only for call-site parity with the Zig original's explicit move semantics, which Rust gets for free. Grep confirms zero callers anywhere in the repo (the only move_ hits are an unrelated struct field in src/sys/lib.rs).
Security risks
None. This is a pure deletion of unreachable code with no runtime behavior; no inputs, no I/O, no state.
Level of scrutiny
Minimal. The change is mechanical dead-code cleanup: removing an uncalled identity function cannot alter program semantics, and cargo check --workspace would catch any missed caller at compile time. The PR description correctly traces why the Zig original was dead too.
Other factors
No CODEOWNERS entry covers this path. No outstanding reviewer comments. The bug-hunting system found nothing. This fits the pattern of recent dead-code-sweep PRs already merged into main (e.g., #31536).
Dead-code sweep of
bun_paths— single item.cargo check --workspacepasses.Why this code exists
Path::move_src/paths/Path.zig:288(move).move()hit (src/install/hosted_git_info.zig:153) targetsextract.Result.move, notPath.moveself-returning no-op (Rust move semantics make it identity)