Skip to content

paths: delete unused Path::move_ no-op#31551

Merged
dylan-conway merged 1 commit into
mainfrom
claude/dead-code-paths
May 29, 2026
Merged

paths: delete unused Path::move_ no-op#31551
dylan-conway merged 1 commit into
mainfrom
claude/dead-code-paths

Conversation

@dylan-conway

Copy link
Copy Markdown
Member

Dead-code sweep of bun_paths — single item.

cargo check --workspace passes.

Why this code exists

Item Zig original Zig callers Status
Path::move_ src/paths/Path.zig:288 (move) 0 — the only .move() hit (src/install/hosted_git_info.zig:153) targets extract.Result.move, not Path.move dead in Zig too — and the Rust port is a self-returning no-op (Rust move semantics make it identity)

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@dylan-conway, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2032b1f9-9bf0-4fa4-88d0-f60bf1246724

📥 Commits

Reviewing files that changed from the base of the PR and between d4b3a3e and 87637b2.

📒 Files selected for processing (1)
  • src/paths/Path.rs

Comment @coderabbitai help to get the list of available commands and usage tips.

@robobun

robobun commented May 29, 2026

Copy link
Copy Markdown
Collaborator
Updated 11:05 PM PT - May 28th, 2026

@dylan-conway, your commit 87637b2 has 1 failures in Build #58854 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 31551

That installs a local version of the PR into your bun-31551 executable, so you can run:

bun-31551 --bun

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — trivial dead-code removal of an identity no-op.

Extended reasoning...

Overview

This PR deletes a single 4-line method, Path::move_, from src/paths/Path.rs. The method body was self — a pure identity function that existed only for call-site parity with the Zig original's explicit move semantics, which Rust gets for free. Grep confirms zero callers anywhere in the repo (the only move_ hits are an unrelated struct field in src/sys/lib.rs).

Security risks

None. This is a pure deletion of unreachable code with no runtime behavior; no inputs, no I/O, no state.

Level of scrutiny

Minimal. The change is mechanical dead-code cleanup: removing an uncalled identity function cannot alter program semantics, and cargo check --workspace would catch any missed caller at compile time. The PR description correctly traces why the Zig original was dead too.

Other factors

No CODEOWNERS entry covers this path. No outstanding reviewer comments. The bug-hunting system found nothing. This fits the pattern of recent dead-code-sweep PRs already merged into main (e.g., #31536).

@dylan-conway dylan-conway merged commit f46fe89 into main May 29, 2026
77 of 78 checks passed
@dylan-conway dylan-conway deleted the claude/dead-code-paths branch May 29, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants