bun_alloc: delete unused MimallocHeapRef, TypedArena, BumpWithFallback#31542
Merged
Claude / Claude Code Review
completed
May 29, 2026 in 7m 11s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bun_alloc/maybe_owned.rs:72-74 |
Stale comment references deleted into_parent() |
| 🟡 Nit | src/bun_alloc/lib.rs:326-327 |
typed-arena dependency now unused in bun_alloc |
Annotations
Check warning on line 74 in src/bun_alloc/maybe_owned.rs
claude / Claude Code Review
Stale comment references deleted into_parent()
The trailing comment block at the bottom of this file still says "keeping one would also forbid moving `self._parent` out in `into_parent(self)`" — but `into_parent` is deleted in this PR. Drop that clause; the preceding sentence about field drop glue stands on its own. Same class of leftover as the `init_default` doc-comment fixed in 3b1c8cc3.
Check warning on line 327 in src/bun_alloc/lib.rs
claude / Claude Code Review
typed-arena dependency now unused in bun_alloc
Removing the `TypedArena<T>` alias drops the only reference to the `typed_arena` crate inside `bun_alloc`, but `src/bun_alloc/Cargo.toml:30` still declares `typed-arena.workspace = true`. Since this PR is a dead-code sweep, drop the now-unused crate-level dependency too (the workspace root entry stays — `ast`, `js_parser`, `css`, etc. depend on it directly).
Loading