Fix crash when starting a compiled executable in a deleted cwd - #31496
Merged
Jarred-Sumner merged 5 commits intoMay 29, 2026
Claude / Claude Code Review
completed
May 28, 2026 in 9m 49s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/jsc_hooks.rs:421-444 |
Stale comment above Transpiler::init match claims 'Err arm is the live path for now' |
Annotations
Check warning on line 444 in src/runtime/jsc_hooks.rs
claude / Claude Code Review
Stale comment above Transpiler::init match claims 'Err arm is the live path for now'
nit: the comment at jsc_hooks.rs:341-344 still says `Transpiler::init` "returns `Err(Error::TODO)` until those surface, so the `Err` arm below is the live path for now" — but this PR rewrote that `Err` arm to abort `VirtualMachine::init`, so the stale sentence now reads as "every VM init aborts". Same cleanup as 81bc75f: drop the first sentence (the second half about `ptr::write` being load-bearing is still correct and should stay).
Loading