-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Restrict crate-internal items to pub(crate) and remove dead code it exposes #31254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e0b8268
Restrict crate-internal items to pub(crate)
Jarred-Sumner 00d95e7
Remove dead AST JSON-serialization facility and empty bun_unicode crate
Jarred-Sumner e1d285c
Remove unconsumed crates: bun_meta, bun_url_jsc, bun_libarchive_sys, …
Jarred-Sumner d8ee30d
Address review feedback
Jarred-Sumner 01fc54b
Deny unreachable_pub workspace-wide
Jarred-Sumner c6bbc02
Merge remote-tracking branch 'origin/main' into claude/pub-crate-demote
Jarred-Sumner 06f7be6
Fix unreachable_pub in the standalone shim build and post-merge code
Jarred-Sumner 3f63077
Audit cross-crate exports: demote, delete dead code, mark the remainder
Jarred-Sumner ee5ad86
Remove empty module shells left by the ES5 table removal
Jarred-Sumner 7915136
Clean up residue from the dead-code deletion pass
Jarred-Sumner e61530e
Merge remote-tracking branch 'origin/main' into claude/pub-crate-demote
Jarred-Sumner 4457dd3
Keep HOST_EXPORT-marked functions pub fn
Jarred-Sumner b995321
Allow debug-only helpers that are dead in release builds
Jarred-Sumner 9abf984
Address review feedback on the audit commit
Jarred-Sumner 81291dd
Keep JS-class payload structs pub for the class codegen
Jarred-Sumner 31497fc
Fix clippy and miri: allow the documented raw-pointer deref, clean up…
Jarred-Sumner 866b54b
Emit pub(crate) from the string-map codegen
Jarred-Sumner 60ef844
Merge remote-tracking branch 'origin/main' into claude/pub-crate-demote
Jarred-Sumner fcf5a20
Merge remote-tracking branch 'origin/main' into claude/pub-crate-demote
Jarred-Sumner 909bc4b
Widen types that appear in pub signatures; address review feedback
Jarred-Sumner f8b2ca0
Deny all warnings workspace-wide and fix every diagnostic
Jarred-Sumner 7b7737e
Fix Windows release build: cfg the core_intrinsics feature, allow lin…
Jarred-Sumner 00d7859
Restore HeapLabel/named_allocator docs; handle wrapped impl headers i…
Jarred-Sumner 72556c0
Fix the JSXElement doc comment's code fences so doctest collection su…
Jarred-Sumner 2d94380
Merge remote-tracking branch 'origin/main' into claude/pub-crate-demote
Jarred-Sumner 4ece90d
Address review: delete dead HeapLabel/named_allocator, fix macro visi…
Jarred-Sumner 672ec73
Remove unused fileToCrate map from find-dead-exports
Jarred-Sumner a9b0374
Reword to_source doc to reference source_from_file_at
Jarred-Sumner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.