Error instead of crashing on deeply nested expressions in the transpiler - #31242
Merged
Claude / Claude Code Review
completed
May 23, 2026 in 16m 22s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/bundler/transpiler/transpiler.test.js:3973 |
Explicit test timeout violates test/CLAUDE.md |
Annotations
Check warning on line 3973 in test/bundler/transpiler/transpiler.test.js
claude / Claude Code Review
Explicit test timeout violates test/CLAUDE.md
nit: test/CLAUDE.md:120 says "**CRITICAL**: Do not set a timeout on tests. Bun already has timeouts." — this `, 60_000` is the only explicit `it()` timeout in transpiler.test.js. There is precedent in the same directory for this crash class (`transpiler-stack-overflow.test.ts:21` uses `1000000`), so this is a low-stakes convention nit; drop the second argument to match the documented rule, or keep it if slow ASAN/CI lanes actually need it.
Loading