Repository navigation
http.request: emit 'error' with AbortError when options.signal aborts #31170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
58906bf
http.request: emit 'error' with AbortError when options.signal aborts
robobun 9e90768
http.request signal: remove abort listener on settle
robobun cd27158
test: await the signal itself in destroy-before-end case
robobun 73aadba
ci: retrigger
robobun 9901e02
http.request signal: detach listener on network-error settle paths
robobun a384341
http.request signal: don't detach listener in maybeEmitClose
robobun 816c2ef
http.request signal: cover sync-throw catch blocks + test cleanup
robobun 0bb08fc
http.request signal: detach listener on res 'end', document early-close
robobun 3a997a9
http.request signal: swallow happy-eyeballs fail() after abort
robobun 993ed24
http.request signal: latch 'error' emission, cover remaining double-e…
robobun bf29985
http.request signal: align lookup err guard with fail()
robobun f0a3ea3
test(http client-signal-abort): await lookupFired instead of Bun.slee…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.