Skip to content

chore: inherit workspace lints in all member crates - #30707

Merged
dylan-conway merged 1 commit into
oven-sh:mainfrom
Boshen:claude/workspace-lints
May 14, 2026
Merged

dylan-conway merged 1 commit into
oven-sh:mainfrom
Boshen:claude/workspace-lints

Conversation

@Boshen

@Boshen Boshen commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds [lints] with workspace = true to every workspace member crate so per-crate manifests opt into the shared [workspace.lints] policy.
  • Lifts the unexpected_cfgs registration for cfg(bun_asan) from bun_core and bun_alloc into [workspace.lints.rust]. Side effect: bun_safety (which uses cfg(bun_asan) without registering it locally) is now covered too.

🤖 Generated with Claude Code


Note: This allows for adding more workspace level lints in the near future.

Adds `[lints]\nworkspace = true` to every workspace member so per-crate
manifests opt into the shared `[workspace.lints]` policy. Also lifts the
`unexpected_cfgs` registration for `cfg(bun_asan)` from `bun_core` and
`bun_alloc` into `[workspace.lints.rust]`, which fixes `bun_safety`
(which uses the cfg without registering it).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: eb57f37f-f0cb-42a7-99f1-3802e0ea268a

📥 Commits

Reviewing files that changed from the base of the PR and between 19d8ade and bddd95b.

📒 Files selected for processing (109)
  • Cargo.toml
  • src/analytics/Cargo.toml
  • src/api/Cargo.toml
  • src/ast/Cargo.toml
  • src/ast_jsc/Cargo.toml
  • src/base64/Cargo.toml
  • src/boringssl/Cargo.toml
  • src/boringssl_sys/Cargo.toml
  • src/brotli/Cargo.toml
  • src/brotli_sys/Cargo.toml
  • src/bun_alloc/Cargo.toml
  • src/bun_bin/Cargo.toml
  • src/bun_core/Cargo.toml
  • src/bun_core_macros/Cargo.toml
  • src/bun_output_tags/Cargo.toml
  • src/bundler/Cargo.toml
  • src/bundler_jsc/Cargo.toml
  • src/bunfig/Cargo.toml
  • src/cares_sys/Cargo.toml
  • src/clap/Cargo.toml
  • src/clap_macros/Cargo.toml
  • src/codegen/Cargo.toml
  • src/collections/Cargo.toml
  • src/crash_handler/Cargo.toml
  • src/csrf/Cargo.toml
  • src/css/Cargo.toml
  • src/css_derive/Cargo.toml
  • src/css_jsc/Cargo.toml
  • src/dispatch/Cargo.toml
  • src/dns/Cargo.toml
  • src/dotenv/Cargo.toml
  • src/errno/Cargo.toml
  • src/event_loop/Cargo.toml
  • src/exe_format/Cargo.toml
  • src/glob/Cargo.toml
  • src/hash/Cargo.toml
  • src/highway/Cargo.toml
  • src/http/Cargo.toml
  • src/http_jsc/Cargo.toml
  • src/http_types/Cargo.toml
  • src/ini/Cargo.toml
  • src/install/Cargo.toml
  • src/install/windows-shim/Cargo.toml
  • src/install_jsc/Cargo.toml
  • src/install_types/Cargo.toml
  • src/io/Cargo.toml
  • src/js/Cargo.toml
  • src/js_parser/Cargo.toml
  • src/js_parser_jsc/Cargo.toml
  • src/js_printer/Cargo.toml
  • src/jsc/Cargo.toml
  • src/jsc_macros/Cargo.toml
  • src/libarchive/Cargo.toml
  • src/libarchive_sys/Cargo.toml
  • src/libdeflate_sys/Cargo.toml
  • src/libuv_sys/Cargo.toml
  • src/lolhtml_sys/Cargo.toml
  • src/md/Cargo.toml
  • src/meta/Cargo.toml
  • src/mimalloc_sys/Cargo.toml
  • src/node-fallbacks/Cargo.toml
  • src/opaque/Cargo.toml
  • src/options_types/Cargo.toml
  • src/output/Cargo.toml
  • src/parsers/Cargo.toml
  • src/patch/Cargo.toml
  • src/patch_jsc/Cargo.toml
  • src/paths/Cargo.toml
  • src/perf/Cargo.toml
  • src/picohttp/Cargo.toml
  • src/picohttp_sys/Cargo.toml
  • src/platform/Cargo.toml
  • src/ptr/Cargo.toml
  • src/resolve_builtins/Cargo.toml
  • src/resolver/Cargo.toml
  • src/router/Cargo.toml
  • src/runtime/Cargo.toml
  • src/s3_signing/Cargo.toml
  • src/safety/Cargo.toml
  • src/semver/Cargo.toml
  • src/semver_jsc/Cargo.toml
  • src/sha_hmac/Cargo.toml
  • src/shell_parser/Cargo.toml
  • src/simdutf_sys/Cargo.toml
  • src/sourcemap/Cargo.toml
  • src/sourcemap_jsc/Cargo.toml
  • src/spawn/Cargo.toml
  • src/spawn_sys/Cargo.toml
  • src/sql/Cargo.toml
  • src/sql_jsc/Cargo.toml
  • src/standalone_graph/Cargo.toml
  • src/sys/Cargo.toml
  • src/sys_jsc/Cargo.toml
  • src/tcc_sys/Cargo.toml
  • src/threading/Cargo.toml
  • src/transpiler/Cargo.toml
  • src/unicode/Cargo.toml
  • src/url/Cargo.toml
  • src/url_jsc/Cargo.toml
  • src/uws/Cargo.toml
  • src/uws_sys/Cargo.toml
  • src/valkey/Cargo.toml
  • src/watcher/Cargo.toml
  • src/which/Cargo.toml
  • src/windows_sys/Cargo.toml
  • src/wyhash/Cargo.toml
  • src/zlib/Cargo.toml
  • src/zlib_sys/Cargo.toml
  • src/zstd/Cargo.toml

Walkthrough

This PR centralizes Rust lint configuration in the workspace to handle cfg(bun_asan) consistently across all crates, replacing scattered local lint configurations with a single workspace-level definition that all crates inherit.

Changes

Centralized Workspace Lint Configuration

Layer / File(s) Summary
Workspace lint configuration definition
Cargo.toml
Root workspace adds [workspace.lints.rust] with unexpected_cfgs rule for cfg(bun_asan) to suppress lint warnings when the configuration is used without explicit --cfg flags.
Crate-level lint inheritance
src/*/Cargo.toml
All 124 crates add [lints] workspace = true to inherit workspace lint rules. Two crates (src/bun_alloc, src/bun_core) replace local [lints.rust] sections that previously managed cfg(bun_asan) warnings.
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides a summary section but does not follow the required template structure with 'What does this PR do?' and 'How did you verify your code works?' sections. Restructure the description to include the required template sections: 'What does this PR do?' and 'How did you verify your code works?' while preserving the detailed summary content.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely describes the main change: inheriting workspace lints across all member crates. It is specific and directly relates to the primary modification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants