docs: correct typo - #30696
docs: correct typo#30696pnodet wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR updates wording for ChangesstringWidth Documentation
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/runtime/utils.mdx`:
- Line 441: Update the sentence describing ambiguousIsNarrow to fix grammar and
reflect the actual behavior: replace the emoji-centric wording with
"ambiguous-width characters" and correct plurality to "1 character" and "2
characters", and state that when ambiguousIsNarrow is true those ambiguous-width
characters are counted as 1 character (narrow) and when false they are counted
as 2 characters (wide); ensure the phrasing matches the option name
ambiguousIsNarrow and is consistent with surrounding docs.
In `@packages/bun-types/bun.d.ts`:
- Line 556: Update the JSDoc for ambiguousIsNarrow to fix grammar and clarify
behavior: change the wording to explicitly mention "ambiguous-width characters
(e.g., some emoji)" and state that when ambiguousIsNarrow is true those
characters are treated as occupying one column (narrow), and when false they are
treated as occupying two columns (wide); update the docstring near the
ambiguousIsNarrow property to use singular/plural correctly and include the
example parenthetical.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2a34959f-2a8f-40cd-97d8-c58fbd286a19
📒 Files selected for processing (2)
docs/runtime/utils.mdxpackages/bun-types/bun.d.ts
|
Thanks for the fix. I am closing this PR as a duplicate. Here is the state on main. The The If you prefer to rebase this branch instead, you can reopen this PR. |
Fix minor typo in docs