install: enforce minimumReleaseAge against lockfile-pinned versions - #30526
Closed
robobun wants to merge 8 commits into
Closed
install: enforce minimumReleaseAge against lockfile-pinned versions#30526robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
May 12, 2026 in 30m 59s
Code review found 1 important issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/install/PackageManager/PopulateManifestCache.zig:203-210 |
Banned 'catch bun.outOfMemory()' pattern fails ban-words.test.ts |
Annotations
Check failure on line 210 in src/install/PackageManager/PopulateManifestCache.zig
claude / Claude Code Review
Banned 'catch bun.outOfMemory()' pattern fails ban-words.test.ts
These three new ` catch bun.outOfMemory()` calls (here and at lines ~222 and ~237) trip the repo's ban-words check — `test/internal/ban-limits.json` sets the limit for this pattern to 0, which is why `test/internal/ban-words.test.ts` is failing in CI on this PR. Replace each with `bun.handleOom(manager.log.addErrorFmt(...))` (or `... catch |e| bun.handleOom(e)`) per the convention in `src/CLAUDE.md`.
Loading