cli: sync PWD env var with --cwd chdir - #30458
Open
robobun wants to merge 3 commits into
Open
Claude / Claude Code Review
completed
May 17, 2026 in 18m 6s
Code review found 1 potential issue
Found 7 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/cli/Arguments.rs:1662-1665 |
SetEnvironmentVariableW declared with extern "C" instead of extern "system" |
Annotations
Check warning on line 1665 in src/runtime/cli/Arguments.rs
claude / Claude Code Review
SetEnvironmentVariableW declared with extern "C" instead of extern "system"
nit: `SetEnvironmentVariableW` is a kernel32 stdcall API, so this should be `unsafe extern "system"` rather than `extern "C"` — matching the documented convention at `src/windows_sys/externs.rs:1306` ("kernel32 stdcall — use extern \"system\"") and the sibling `GetEnvironmentVariableW` declaration at `src/sys/windows/mod.rs:4886`. On x86_64/aarch64 Windows the two ABIs are identical so there's no runtime impact on supported targets, but it's a one-word fix for consistency. (The same pre-existing
Loading