-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix use-after-free in Bun.Transpiler.transform() error reporting #30309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
6
commits into
main
Choose a base branch
from
farm/ee469c7e/transpiler-transform-log-uaf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6776255
Fix use-after-free in Bun.Transpiler.transform() error reporting
robobun f64ce52
[autofix.ci] apply automated fixes
autofix-ci[bot] 8661224
Free cloned log messages in TransformTask.deinit()
robobun 5eada11
Run regression test in subprocess so crash registers as test failure
robobun 22c4a7b
Use bun -e for subprocess regression test
robobun ba94fd0
Drop explicit test timeout
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
test/js/bun/transpiler/transpiler-transform-error-uaf.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe } from "harness"; | ||
|
|
||
| test("async transform() rejecting with parse errors does not read freed memory", async () => { | ||
| const script = ` | ||
| const transpiler = new Bun.Transpiler(); | ||
| const bad = Buffer.alloc(1000, "const a = 1;\\n").toString() + "const x = ;"; | ||
| const results = await Promise.all( | ||
| Array.from({ length: 20 }, () => transpiler.transform(bad).then(() => null, e => e)), | ||
| ); | ||
| for (const e of results) { | ||
| if (!(e instanceof Error)) throw new Error("expected Error, got " + e); | ||
| const text = e.errors ? e.errors.map(String).join("\\n") : String(e); | ||
| if (!/already been declared|Unexpected/.test(text)) throw new Error("bad message: " + text); | ||
| } | ||
| console.log("ok"); | ||
| `; | ||
|
|
||
| const { exitCode, stdout, stderr, signalCode } = Bun.spawnSync({ | ||
| cmd: [bunExe(), "-e", script], | ||
| env: bunEnv, | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const out = stdout.toString(); | ||
| const err = stderr.toString(); | ||
| expect({ exitCode, signalCode, out, err }).toEqual({ exitCode: 0, signalCode: undefined, out: "ok\n", err: "" }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.