Guard MessagePortChannel state with a per-channel Lock - #29991
Closed
robobun wants to merge 1 commit into
Closed
Claude / Claude Code Review
completed
Apr 30, 2026 in 34m 12s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/workers/message-channel.test.ts:401-402 |
Explicit per-test timeout violates test/CLAUDE.md convention |
Annotations
Check warning on line 402 in test/js/web/workers/message-channel.test.ts
claude / Claude Code Review
Explicit per-test timeout violates test/CLAUDE.md convention
Minor: `test/CLAUDE.md` says "Do not set a timeout on tests. Bun already has timeouts", and this passes `120_000` as an explicit per-test timeout. That said, 3 × ~17s under debug/ASAN clearly exceeds the 5s default and plenty of other slow tests in `test/js/` do the same, so this is informational only — feel free to keep it (or swap to `setDefaultTimeout` if you'd rather match the files that go that route).
Loading