Fix stack overflow when inspecting JSX elements with circular references#29931
Closed
robobun wants to merge 2 commits into
Closed
Fix stack overflow when inspecting JSX elements with circular references#29931robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Apr 29, 2026 in 9m 38s
Code review found 1 potential issue
Found 6 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/test/pretty-format-overflow.test.ts:88-93 |
Assert stderr content before exitCode (CLAUDE.md guideline) |
Annotations
Check warning on line 93 in test/js/bun/test/pretty-format-overflow.test.ts
claude / Claude Code Review
Assert stderr content before exitCode (CLAUDE.md guideline)
nit: per root CLAUDE.md, when spawning processes the test should assert on `stderr` content *before* `exitCode` so that a regression surfaces useful diagnostics. If the spawned `bun test` segfaults again (the very thing this test guards against), `exitCode` will be `null`/signal-coded and the failure will just say "expected null to be 1" without showing what stderr contained. Move `expect(exitCode).toBe(1)` after the stderr assertions (the pre-existing test above has the same ordering and could
Loading