Skip to content

test: avoid TLA self-cycle in bun-main dynamic-import test #29738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 2 commits into from
Apr 26, 2026
+15 −7
Merged

test: avoid TLA self-cycle in bun-main dynamic-import test #29738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d86be
test: avoid TLA self-cycle in bun-main dynamic-import test
dylan-conway Apr 26, 2026
ca81de4
test: chain .catch so assertion throws in fulfillment handler are rep…
dylan-conway Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions test/js/bun/resolve/bun-main-entry-point.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,22 @@ test.concurrent("dynamic import('bun:main') returns the wrapper module", async (
// package.json disables auto-install so a regression in the bun:main alias
// cannot silently fall through to fetching the npm `main` package.
"package.json": "{}",
// bun:main statically imports entry.mjs, so awaiting import("bun:main")
// at the top level of entry.mjs is a TLA self-cycle that never resolves.
// Defer the import to a .then() so entry.mjs (and therefore bun:main)
// can finish evaluating first.
"entry.mjs": `
const m = await import("bun:main");
if (m[Symbol.toStringTag] !== "Module") throw new Error("expected module namespace, got " + Object.prototype.toString.call(m));
// The wrapper has no named exports. The npm \`main\` package (what this
// resolved to before the alias fix) exports {default,length,name,prototype}.
const keys = Object.keys(m);
if (keys.length !== 0) throw new Error("expected empty wrapper namespace, got keys: " + keys.join(","));
console.log("OK");
import("bun:main").then(m => {
if (m[Symbol.toStringTag] !== "Module") throw new Error("expected module namespace, got " + Object.prototype.toString.call(m));
// The wrapper has no named exports. The npm \`main\` package (what this
// resolved to before the alias fix) exports {default,length,name,prototype}.
const keys = Object.keys(m);
if (keys.length !== 0) throw new Error("expected empty wrapper namespace, got keys: " + keys.join(","));
console.log("OK");
}).catch(e => {
console.error(String(e));
process.exit(1);
});
`,
});
await using proc = Bun.spawn({
Expand Down
Loading