Skip to content

build: disable exceptions for highway on Windows (clang-cl) #29645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 3 commits into from
Apr 23, 2026
+5 −3
Merged

build: disable exceptions for highway on Windows (clang-cl) #29645

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc84321
build: drop -fno-exceptions from highway cflags on Windows
dylan-conway Apr 23, 2026
31b9062
build: actually disable exceptions for highway on Windows
dylan-conway Apr 23, 2026
9f1f73f
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/build/deps/highway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@
],
includes: ["."],
defines: { HWY_STATIC_DEFINE: true },
// -fmath-errno isn't a CLOption (clang-cl warns); highway's own
// cmake skips it in the MSVC branch.
cflags: cfg.windows ? ["-fno-exceptions"] : ["-fno-exceptions", "-fmath-errno"],
// Neither -fno-exceptions nor -fmath-errno are CLOptions (clang-cl
// warns "unknown argument ignored"). globalFlags supplies /EH* and
// /GR- on Windows; highway's own cmake skips both in its MSVC branch.
cflags: cfg.windows ? [] : ["-fno-exceptions", "-fmath-errno"],

Check notice on line 49 in scripts/build/deps/highway.ts

View check run for this annotation

Claude / Claude Code Review

Comment cites globalFlags /EH* as disabling exceptions, but flags.ts:189 sets /EHsc (enable) 

Heads up: the comment cites "globalFlags supplies /EH*" as the Windows replacement for `-fno-exceptions`, but `scripts/build/flags.ts:189` actually emits `/EHsc`, which **enables** synchronous C++ exceptions in MSVC/clang-cl — its own `desc` string describes `/EHs-c-` (disable), so flags.ts has a pre-existing intent/value typo. This PR is behaviorally a no-op (clang-cl was already ignoring `-fno-exceptions`), but the rationale leans on a buggy entry; the real fix is changing flags.ts:189 to `/EH
Comment thread
claude[bot] marked this conversation as resolved.
Outdated
};

// clang-cl on arm64-windows doesn't define __ARM_NEON even though NEON
Expand Down
Loading