build: enable LTO for bun-zig.o - #29618
Merged
Merged
Claude / Claude Code Review
completed
Apr 23, 2026 in 5m 0s
Code review found 1 potential issue
Found 6 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/zig.ts:442 |
Stale comment references removed stable-compiler / return-0 logic |
Annotations
Check warning on line 442 in scripts/build/zig.ts
claude / Claude Code Review
Stale comment references removed stable-compiler / return-0 logic
The comment at lines 446-448 still says "MUST be 0 on the stable compiler — see codegenThreads()", but this PR removed the stable/parallel compiler split and `codegenThreads()` no longer ever returns 0 (its minimum is now 1). Consider updating this comment to drop the stale "stable compiler" / "0" reference.
Loading