Skip to content

deps(mimalloc): set MI_OVERRIDE=OFF on Windows - #29467

Merged
dylan-conway merged 2 commits into
mainfrom
claude/interesting-mahavira-c5f1c5
Apr 18, 2026
Merged

deps(mimalloc): set MI_OVERRIDE=OFF on Windows#29467
dylan-conway merged 2 commits into
mainfrom
claude/interesting-mahavira-c5f1c5

deps(mimalloc): set MI_OVERRIDE=OFF on Windows

684dd94
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 18, 2026 in 5m 37s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit scripts/build/deps/mimalloc.ts:86-93 Decision matrix comment omits Windows entry

Annotations

Check warning on line 93 in scripts/build/deps/mimalloc.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Decision matrix comment omits Windows entry 

The decision matrix comment (lines 61–68) lists ASAN, macOS, and Linux override policies but omits a Windows entry, even though this PR adds an explicit `cfg.windows` branch setting `MI_OVERRIDE=OFF`. A reader consulting the matrix to understand Windows override policy would find no entry there; they must discover the rationale from the inline comment deeper in the function.
View more details on Claude