Upgrade WebKit to 87fd0daba19a (module-loader rewrite) - #29393
Merged
Claude / Claude Code Review
completed
Apr 25, 2026 in 11m 23s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/deps/webkit.ts:6 |
process.versions.webkit now includes 'autobuild-' prefix instead of bare SHA |
Annotations
Check warning on line 6 in scripts/build/deps/webkit.ts
claude / Claude Code Review
process.versions.webkit now includes 'autobuild-' prefix instead of bare SHA
`WEBKIT_VERSION` is now `"autobuild-f5f6c3f654bd…"` instead of the bare SHA, which flows verbatim through `depVersionsHeader.ts:59` → `BUN_VERSION_WEBKIT` → `process.versions.webkit` (BunProcess.cpp:215) and the inspector's `WebKit-Version` header (debugger.ts:515) — violating the comment at depVersionsHeader.ts:54-57 ("process.versions should show the clean commit hash"). Since `prebuiltUrl()` (line 76) already handles both forms via `startsWith("autobuild-")`, this can simply be the bare SHA `
Loading