Upgrade WebKit to 4d5e75ebd84a14edbc7ae264245dcd77fe597c10#29294
Conversation
|
Updated 10:36 PM PT - Apr 13th, 2026
❌ @Jarred-Sumner, your commit 4f86e7c has 3 failures in
🧪 To try this PR locally: bunx bun-pr 29294That installs a local version of the PR into your bun-29294 --bun |
There was a problem hiding this comment.
LGTM — simple version hash bump.
Extended reasoning...
Overview
Single-line change updating the WebKit commit hash in scripts/build/deps/webkit.ts. The underlying WebKit change is a narrow Windows-only memory optimization in pas_compact_heap_reservation.c (+15/−2 lines): switching from eager VirtualAlloc(MEM_COMMIT|MEM_RESERVE) to lazy commit on bump, matching the existing PlayStation path. Linux/macOS are unaffected.
Security Risks
None. This is a dependency version bump with no auth, crypto, or permission changes. The WebKit change itself reduces memory footprint without altering security boundaries.
Level of Scrutiny
Minimal scrutiny required. This follows the established automated WebKit upgrade pattern seen in the repo's recent commit history (multiple similar upgrades visible in the log). The PR description confirms no ABI-breaking changes and no Zig binding updates needed.
Other Factors
No CODEOWNER-sensitive files touched. No bugs found by the hunting system. No outstanding reviewer comments. Automated build is already triggered.
|
Found 3 issues this PR may fix:
🤖 Generated with Claude Code |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
…9294) Upgrades WebKit from `8b7f6f70` → `4d5e75eb` (1 commit). ## bmalloc / libpas Changes - **Windows: lazy-commit the 128 MB compact-heap reservation** ([4d5e75eb](oven-sh/WebKit@4d5e75eb)). On Windows, `pas_compact_heap_reservation` previously committed the entire 128 MB region eagerly via `VirtualAlloc(MEM_COMMIT|MEM_RESERVE)` because `pas_page_malloc` lacks a reserve-only verb there. Only ~3–8 MB past the bump pointer is ever actually used, and the scavenger never reclaims this region. This change extends the existing PlayStation reserve-then-commit-on-bump path to Windows. Linux/macOS are unaffected (already lazy via `mmap MAP_NORESERVE`). ## Compatibility Notes - `JSType.h`: no changes — `src/bun.js/bindings/JSType.zig` needs no update. - WebCore bindings codegen (`Source/WebCore/bindings/scripts/`): no changes. - Only file touched: `Source/bmalloc/libpas/src/libpas/pas_compact_heap_reservation.c` (+15/−2).
…9294) Upgrades WebKit from `8b7f6f70` → `4d5e75eb` (1 commit). ## bmalloc / libpas Changes - **Windows: lazy-commit the 128 MB compact-heap reservation** ([4d5e75eb](oven-sh/WebKit@4d5e75eb)). On Windows, `pas_compact_heap_reservation` previously committed the entire 128 MB region eagerly via `VirtualAlloc(MEM_COMMIT|MEM_RESERVE)` because `pas_page_malloc` lacks a reserve-only verb there. Only ~3–8 MB past the bump pointer is ever actually used, and the scavenger never reclaims this region. This change extends the existing PlayStation reserve-then-commit-on-bump path to Windows. Linux/macOS are unaffected (already lazy via `mmap MAP_NORESERVE`). ## Compatibility Notes - `JSType.h`: no changes — `src/bun.js/bindings/JSType.zig` needs no update. - WebCore bindings codegen (`Source/WebCore/bindings/scripts/`): no changes. - Only file touched: `Source/bmalloc/libpas/src/libpas/pas_compact_heap_reservation.c` (+15/−2).
Upgrades WebKit from
8b7f6f70→4d5e75eb(1 commit).bmalloc / libpas Changes
pas_compact_heap_reservationpreviously committed the entire 128 MB region eagerly viaVirtualAlloc(MEM_COMMIT|MEM_RESERVE)becausepas_page_malloclacks a reserve-only verb there. Only ~3–8 MB past the bump pointer is ever actually used, and the scavenger never reclaims this region. This change extends the existing PlayStation reserve-then-commit-on-bump path to Windows. Linux/macOS are unaffected (already lazy viammap MAP_NORESERVE).Compatibility Notes
JSType.h: no changes —src/bun.js/bindings/JSType.zigneeds no update.Source/WebCore/bindings/scripts/): no changes.Source/bmalloc/libpas/src/libpas/pas_compact_heap_reservation.c(+15/−2).