Conversation
Fix link to CPU Requirements
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughREADME.md was updated to modify a documentation link reference. An anchor link in the x64 "illegal instruction" guidance section was changed from Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Confirming this is the fix to keep. The docs heading is |
|
Yes, merging #36465 covers this. Its README hunk produces the same line 50 as this PR, so once it lands this one has nothing left to apply and can be closed. I re-checked #36465 against today's main before answering. It still merges cleanly (the only upstream change to any file it touches is the control character fix in If you would rather land this one first so the author gets credit for the link fix, that works too. I merged them in that order locally and #36465 still applies without conflicts, since the README change is identical in both. |
|
Thanks for the fix, and for finding the broken link first. The same change to this README line landed on main in #36465 (commit c3082a8) as part of a larger docs update. Line 50 of README.md on main is now identical to the line this PR adds, so there is nothing left for this PR to apply. The link target I am closing this PR instead of merging it, because a merge now would record no change. |
Fix link to CPU Requirements
What does this PR do?
Fix link to CPU Requirements in README.md file
How did you verify your code works?
Just click to link and see that now it redirect to valid section with CPU Requirements.