Repository navigation
ci: fail loudly when artifact download times out - #29039
Merged
Merged
Claude / Claude Code Review
completed
Apr 8, 2026 in 13m 57s
Code review found 1 important issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | scripts/runner.node.mjs:1975-1988 |
Non-timeout spawnSafe failures silently ignored |
Annotations
Check failure on line 1988 in scripts/runner.node.mjs
claude / Claude Code Review
Non-timeout spawnSafe failures silently ignored
The PR only checks `error === "timeout"` but does not check the `ok` field, leaving all other spawnSafe failure modes (non-zero exit codes like `"code 1"`, `"spawn error"`, signals like `"SIGKILL"`) silently ignored. When buildkite-agent artifact download fails for any non-timeout reason, the code falls through to `readdirSync(releasePath)` and — if a stale or partial zip exists from a prior run or an earlier loop iteration — breaks out of the download loop and proceeds to use that wrong binary.
Loading