-
Notifications
You must be signed in to change notification settings - Fork 4.7k
udp: surface IP_RECVERR ICMP errors and MSG_TRUNC truncation flag #28827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // Coverage for the fifth parameter of Bun.udpSocket's `data` callback | ||
| // (`ReceiveFlags.truncated` from MSG_TRUNC) and for Linux's IP_RECVERR | ||
| // surfacing ICMP errors as `error` events on the socket. | ||
|
|
||
| import { udpSocket } from "bun"; | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { isLinux } from "harness"; | ||
|
|
||
| describe("udpSocket() receive flags", () => { | ||
| test("data callback receives flags object with truncated=false for normal packets", async () => { | ||
| const { promise, resolve, reject } = Promise.withResolvers<unknown>(); | ||
| const client = await udpSocket({}); | ||
| const server = await udpSocket({ | ||
| socket: { | ||
| data(_socket, _data, _port, _address, flags) { | ||
| resolve(flags); | ||
| }, | ||
| error(_socket, err) { | ||
| reject(err); | ||
| }, | ||
| }, | ||
| }); | ||
| function sendRec() { | ||
| if (!client.closed) { | ||
| client.send("hello", server.port, "127.0.0.1"); | ||
| setTimeout(sendRec, 10); | ||
| } | ||
| } | ||
| sendRec(); | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| try { | ||
| const flags = await promise; | ||
| expect(flags).toEqual({ truncated: false }); | ||
| } finally { | ||
| client.close(); | ||
| server.close(); | ||
| } | ||
| }); | ||
|
|
||
| // IP_RECVERR is Linux-specific. On BSDs and Windows, ICMP errors on | ||
| // unconnected UDP sockets either propagate by default or are delivered | ||
| // through different channels that we don't currently surface. | ||
| test.skipIf(!isLinux)( | ||
| "surfaces ECONNREFUSED from ICMP port unreachable (IP_RECVERR) and keeps the socket usable", | ||
| async () => { | ||
| const { promise: errPromise, resolve: resolveErr } = Promise.withResolvers<Error & { code?: string }>(); | ||
| const { promise: msgPromise, resolve: resolveMsg } = Promise.withResolvers<string>(); | ||
|
|
||
| const receiver = await udpSocket({ | ||
| socket: { | ||
| data(_socket, data) { | ||
| resolveMsg(data.toString()); | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const sender = await udpSocket({ | ||
| socket: { | ||
| error(err: Error & { code?: string }) { | ||
| resolveErr(err); | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| // Send to a closed port on localhost. The kernel replies with ICMP | ||
| // port unreachable; with IP_RECVERR the next recv surfaces ECONNREFUSED. | ||
| let gotError = false; | ||
| function sendDead() { | ||
| if (!gotError && !sender.closed) { | ||
| sender.send("dead", 1, "127.0.0.1"); | ||
| setTimeout(sendDead, 10); | ||
| } | ||
| } | ||
| sendDead(); | ||
|
|
||
| try { | ||
| const err = await errPromise; | ||
| gotError = true; | ||
| expect(err?.code).toBe("ECONNREFUSED"); | ||
| // The sender socket must remain usable after an ICMP error. | ||
| expect(sender.closed).toBe(false); | ||
|
|
||
| function sendAlive() { | ||
| if (!sender.closed && !receiver.closed) { | ||
| sender.send("alive", receiver.port, "127.0.0.1"); | ||
| setTimeout(sendAlive, 10); | ||
| } | ||
| } | ||
| sendAlive(); | ||
| expect(await msgPromise).toBe("alive"); | ||
| } finally { | ||
| sender.close(); | ||
| receiver.close(); | ||
| } | ||
| }, | ||
| ); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.