-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix: return empty blob promise when ByteBlobLoader store is already consumed #28499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d257425
fix: return empty blob promise when ByteBlobLoader store is already c…
robobun 4fbdb4d
[autofix.ci] apply automated fixes
autofix-ci[bot] cac5058
test: regression test for blob stream bytes after body consumed
robobun f384f94
retry CI (infra timeouts)
robobun 75681f3
[autofix.ci] apply automated fixes
autofix-ci[bot] f6b3630
fix: return empty blob promise when ByteBlobLoader store is already c…
robobun 4fb0b64
[autofix.ci] apply automated fixes
autofix-ci[bot] f4e468d
retry CI (macOS expired)
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { expect, test } from "bun:test"; | ||
|
|
||
| test("bytes() on consumed blob ReadableStream returns valid result", async () => { | ||
| // Create a blob-backed stream and fully consume it via reader | ||
| const blob = new Blob(["test data"]); | ||
| const stream = blob.stream(); | ||
| const reader = stream.getReader(); | ||
| const chunks: Uint8Array[] = []; | ||
| while (true) { | ||
| const { value, done } = await reader.read(); | ||
| if (done) break; | ||
| chunks.push(value); | ||
| } | ||
| reader.releaseLock(); | ||
|
|
||
| // Stream is closed, source store is consumed. | ||
| // Calling bytes() should return a valid empty Uint8Array, not crash. | ||
| // Without the fix, the native toBufferedValue returns .zero without | ||
| // setting an exception, causing an assertion failure in debug builds. | ||
| const result = await stream.bytes(); | ||
| expect(result).toBeInstanceOf(Uint8Array); | ||
| expect(result.length).toBe(0); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.