-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ws: support upgrade and unexpected-response events #28114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alii
wants to merge
24
commits into
main
Choose a base branch
from
ali/ws-upgrade-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a8c01ac
ws: support upgrade and unexpected-response events
d88e35c
ws: addEventListener returns undefined; drop explicit test timeouts
fc51f8c
[autofix.ci] apply automated fixes
autofix-ci[bot] 287d4c7
ws: dispatch non-101 chunked responses immediately; Buffer.alloc in test
8870e90
ws: drop vestigial self-alias guard; don't leak noopBridgeListener
785a88d
ws: coalesce handshake response headers like Node IncomingMessage
14dc45c
ws: dispatch bodiless non-101 handshake responses immediately
robobun c4bd364
[autofix.ci] apply automated fixes
autofix-ci[bot] 83c2d50
ci: retrigger
robobun 84f8d5e
ws: correct SAFETY/doc comments on handshake header-slice lifetime
robobun c2912f7
ws: fix use-after-free when terminate() is called in 'unexpected-resp…
robobun 872f259
[autofix.ci] apply automated fixes
autofix-ci[bot] abc1a91
test: drop unused stderr destructure from RST-UAF regression test
robobun cdb7b42
ws: suppress native error after 'unexpected-response' for addEventLis…
robobun 02e85bb
[autofix.ci] apply automated fixes
autofix-ci[bot] 66d76cb
ws: only suppress native error when unexpected-response fired; dedupe…
robobun 25bd646
[autofix.ci] apply automated fixes
autofix-ci[bot] e26d51c
ws: document the ext-slot-take unsafe block in handle_close (clippy)
robobun 7c68a6d
ws: don't double-emit 'error' for non-101 with on('error') but no une…
robobun 5edeb2c
[autofix.ci] apply automated fixes
autofix-ci[bot] 1a32241
ws: fix 'error' suppression when on() and addEventListener/onerror ar…
robobun a784b3c
[autofix.ci] apply automated fixes
autofix-ci[bot] f49a485
ws: fire 'upgrade' and 'open' under one event-loop scope on 101
robobun 0b89041
ws: dedup addEventListener('upgrade'/'unexpected-response') and clear…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
530 changes: 496 additions & 34 deletions
530
src/http_jsc/websocket_client/WebSocketUpgradeClient.rs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.