Skip to content

fix(windows): disable bmalloc/libpas linking to fix crash #28098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 4 commits into from
Closed

fix(windows): disable bmalloc/libpas linking to fix crash #28098

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01c45f8
fix(windows): disable bmalloc/libpas linking to fix crash
Mar 14, 2026
523a2fd
fix(build): add CI guard against bmalloc/libpas on Windows
Mar 14, 2026
83317f1
ci: retrigger build
Mar 14, 2026
b71b6d6
fix(windows): add TODO for disabling bmalloc/libpas on Windows
Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmake/targets/BuildBun.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,6 @@ if(WIN32)
target_link_libraries(${bun} PRIVATE
${WEBKIT_LIB_PATH}/WTF.lib
${WEBKIT_LIB_PATH}/JavaScriptCore.lib
${WEBKIT_LIB_PATH}/bmalloc.lib
${WEBKIT_LIB_PATH}/sicudtd.lib
${WEBKIT_LIB_PATH}/sicuind.lib
${WEBKIT_LIB_PATH}/sicuucd.lib
Expand All @@ -1278,7 +1277,6 @@ if(WIN32)
target_link_libraries(${bun} PRIVATE
${WEBKIT_LIB_PATH}/WTF.lib
${WEBKIT_LIB_PATH}/JavaScriptCore.lib
${WEBKIT_LIB_PATH}/bmalloc.lib
${WEBKIT_LIB_PATH}/sicudt.lib
${WEBKIT_LIB_PATH}/sicuin.lib
${WEBKIT_LIB_PATH}/sicuuc.lib
Expand Down
9 changes: 7 additions & 2 deletions scripts/build/deps/webkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,10 @@ export const webkit: Dependency = {
// it. If a future version drops libbmalloc.a, you'll get a clear
// "file not found" at link time (not silent omission + cryptic
// undefined symbols).
const libs = [...coreLibs(cfg), ...prebuiltIcuLibs(cfg), bmallocLib(cfg)];
//
// Windows: bmalloc/libpas is disabled due to crash-causing instability
// (see #20931, #26982, #26985, #28097).
const libs = [...coreLibs(cfg), ...prebuiltIcuLibs(cfg), ...(cfg.windows ? [] : [bmallocLib(cfg)])];
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

const includes = ["include"];
// Linux/windows: ICU headers under wtf/unicode. macOS: deleted by
Expand All @@ -281,7 +284,9 @@ export const webkit: Dependency = {
// which source.ts appends to the resolved libs automatically. Listing
// them here would make dep_build also claim to produce them (dup error).
// Posix uses system ICU (linked via -licu* in bun.ts).
const libs = [...coreLibs(cfg), bmallocLib(cfg)];
// Windows: bmalloc/libpas is disabled due to crash-causing instability
// (see #20931, #26982, #26985, #28097).
const libs = [...coreLibs(cfg), ...(cfg.windows ? [] : [bmallocLib(cfg)])];

const includes = [
// ABSOLUTE — resolved here because they're in the build dir, not src.
Expand Down
Loading