Skip to content

Update WebKit - #26549

Merged
Jarred-Sumner merged 3 commits into
mainfrom
dylan/sync-webkit
Jan 29, 2026
Merged

Jarred-Sumner merged 3 commits into
mainfrom
dylan/sync-webkit

Conversation

@dylan-conway

Copy link
Copy Markdown
Member

What does this PR do?

Includes oven-sh/WebKit@9a2cc42

Fixes ##26525

How did you verify your code works?

CI

@robobun

robobun commented Jan 29, 2026 •

Copy link
Copy Markdown
Collaborator
Updated 2:28 AM PT - Jan 29th, 2026

❌ @Jarred-Sumner, your commit 2ffb0b5 has 2 failures in Build #36085 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 26549

That installs a local version of the PR into your bun-26549 executable, so you can run:

bun-26549 --bun

@coderabbitai

coderabbitai Bot commented Jan 29, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Removes a runtime MACOS_VERSION vs CMAKE_OSX_DEPLOYMENT_TARGET fatal check from cmake/tools/SetupMacSDK.cmake, updates the fallback WEBKIT_VERSION value in cmake/tools/SetupWebKit.cmake, and applies non-functional formatting changes in several docs (docs/*).

Changes

Cohort / File(s) Summary
CMake: macOS SDK
cmake/tools/SetupMacSDK.cmake
Removed the runtime check that compared MACOS_VERSION against CMAKE_OSX_DEPLOYMENT_TARGET which previously emitted a fatal error when the OS version was older; other min-target logic and SDK-path detection remain.
CMake: WebKit default
cmake/tools/SetupWebKit.cmake
Changed the default fallback value for WEBKIT_VERSION from cc5e0bddf7eae1d820cf673158845fe9bd83c094 to 9a2cc42ae1bf693a0fd0ceb9b1d7d965d9cfd3ea.
Documentation formatting
docs/bundler/index.mdx, docs/project/benchmarking.mdx, docs/runtime/utils.mdx
Non-functional edits: changed JavaScript example string delimiters from single to double quotes and adjusted table/header/comment formatting and spacing.

Possibly related PRs

  • Update WebKit #26549: Modifies the same CMake files (SetupMacSDK.cmake and SetupWebKit.cmake) and documentation; appears to touch the identical runtime-check removal and WebKit default update.
  • update WebKit #26324: Updates cmake/tools/SetupWebKit.cmake (changes default WEBKIT_VERSION and adds WEBKIT_TAG logic), closely related to the WebKit-default change.
  • Upgrade WebKit #22499: Changes the fallback WEBKIT_VERSION in cmake/tools/SetupWebKit.cmake, directly related to this PR's WebKit version update.
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update WebKit' is vague and generic, lacking specificity about the actual changes made in the changeset. Consider a more descriptive title that captures the primary change, such as 'Update WebKit to autobuild-preview-pr-149-a9ae9224' or include key fixes/issues being addressed.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the required template with both sections completed, providing context and verification details.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@cmake/tools/SetupWebKit.cmake`:
- Around line 4-5: The WEBKIT_VERSION default value is set to a non-existent tag
("autobuild-preview-pr-149-a9ae9224") which will cause downloads to fail; update
the set(WEBKIT_VERSION ...) call to a valid oven-sh/WebKit autobuild tag (or a
stable release tag) by replacing the string literal in the set(WEBKIT_VERSION
...) invocation with an existing tag value, e.g., fetch the repo tags and pick a
current autobuild tag, or change to a known-good tag like
"autobuild-preview-<valid-hash>" so the build can find the assets.

Comment thread cmake/tools/SetupWebKit.cmake Resolved
@Jarred-Sumner
Jarred-Sumner merged commit b64edcb into main Jan 29, 2026
3 of 6 checks passed
@Jarred-Sumner
Jarred-Sumner deleted the dylan/sync-webkit branch January 29, 2026 09:22
xhjkl pushed a commit to xhjkl/bun that referenced this pull request May 14, 2026
### What does this PR do?

Includes
oven-sh/WebKit@9a2cc42

Fixes #oven-sh#26525

### How did you verify your code works?

CI

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants