Repository navigation
feat(install): add --offline and --prefer-offline flags for cache-based installs #26227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0b36e87
d1c8189
aa684a1
51ae679
55a0966
3323de0
6fe42a8
60a7638
20a6359
0fb6a33
0eea51c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1091,9 +1091,10 @@ if(WIN32) | |
| endif() | ||
| endif() | ||
|
|
||
| option(BUN_USE_LD_NEW "Use ld_new linker on macOS (disable for Nix builds)" ON) | ||
| if(APPLE) | ||
| target_link_options(${bun} PUBLIC | ||
| -Wl,-ld_new | ||
| $<$<BOOL:${BUN_USE_LD_NEW}>:-Wl,-ld_new> | ||
| -Wl,-no_compact_unwind | ||
| -Wl,-stack_size,0x1200000 | ||
| -fno-keep-static-consts | ||
|
Comment on lines
+1094
to
1100
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: rg -n "BUN_USE_LD_NEW" -C 2Repository: oven-sh/bun Length of output: 563 🏁 Script executed: # Search for files that might configure or pass CMAKE options
find . -type f \( -name "CMakeLists.txt" -o -name "*.nix" -o -name "*.github*" -o -name "Makefile" \) | head -20Repository: oven-sh/bun Length of output: 214 🏁 Script executed: # Also search for patterns that pass CMAKE options
rg -n "BUN_USE_LD_NEW|add_subdirectory|target_link_options" --type cmake | grep -i "bun_use\|ld_new\|subdirectory" | head -30Repository: oven-sh/bun Length of output: 247 🏁 Script executed: # Check Nix build files for BUN_USE_LD_NEW or macOS-specific options
fd -e nix | head -20Repository: oven-sh/bun Length of output: 74 🏁 Script executed: # Check if CMakeLists.txt passes this option when including BuildBun.cmake
rg -n "BUN_USE_LD_NEW|BuildBun" CMakeLists.txt -C 3Repository: oven-sh/bun Length of output: 134 🏁 Script executed: # Check Nix files for BUN_USE_LD_NEW or CMAKE option passing
rg -n "BUN_USE_LD_NEW|cmake.*-D|build.*flags" flake.nix shell.nix -C 2Repository: oven-sh/bun Length of output: 37 🏁 Script executed: # Search for any cmake invocation that might set this option
rg -n "\-DBUN_USE_LD_NEW" --type cmakeRepository: oven-sh/bun Length of output: 37 🏁 Script executed: # Check how nix files configure cmake
cat flake.nix | head -100Repository: oven-sh/bun Length of output: 2792 🏁 Script executed: # Check shell.nix as well
cat shell.nix | head -50Repository: oven-sh/bun Length of output: 1007 The option's help text contradicts the actual configuration: it says "disable for Nix builds" but Nix builds do not disable it. The Either wire the option into the Nix build by passing 🤖 Prompt for AI Agents |
||
|
|
@@ -1305,6 +1306,8 @@ list(TRANSFORM BUN_DEPENDENCIES TOLOWER OUTPUT_VARIABLE BUN_TARGETS) | |
| add_custom_target(dependencies DEPENDS ${BUN_TARGETS}) | ||
|
|
||
| if(APPLE) | ||
| # macOS uses system icucore library for ICU functionality | ||
| # The prebuilt WebKit is compiled against icucore and expects its non-versioned symbols | ||
| target_link_libraries(${bun} PRIVATE icucore resolv) | ||
| target_compile_definitions(${bun} PRIVATE U_DISABLE_RENAMING=1) | ||
| endif() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Gate
-Wl,-ld_newremoval to avoid changing default macOS linker behavior unintentionally.If this is only required for Nix builds, consider an option/conditional so non‑Nix macOS builds retain the prior linker.
🔧 Possible gating option
📝 Committable suggestion
🤖 Prompt for AI Agents