Skip to content

perf(tests): add virtual mode to bundler tests for faster execution #26218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 13 commits into from
Closed

perf(tests): add virtual mode to bundler tests for faster execution #26218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fce1468
perf(tests): add virtual mode to itBundled for in-memory builds
Jan 18, 2026
a22f005
perf(tests): convert more CSS tests to virtual mode
Jan 18, 2026
32cdb2c
perf(tests): convert 7 esbuild CSS tests to virtual mode
Jan 18, 2026
07bdea0
fix(tests): address code review feedback for virtual mode
Jan 18, 2026
6dcd166
Address code review feedback for virtual mode
Jan 18, 2026
19606f0
Address additional code review feedback
Jan 18, 2026
85ca1a6
Revert esbuild/css.test.ts tests to non-virtual mode
Jan 18, 2026
44340bf
Revert all CSS tests with path-dependent expectations to non-virtual …
Jan 18, 2026
8695e45
Retry CI build (infrastructure issue with SetupBuildkite.cmake)
Jan 18, 2026
8bac1dd
Remove comments from esbuild/css.test.ts
Jan 18, 2026
c04ee28
Add virtual: true to WPT CSS tests
Jan 18, 2026
18322da
Fix virtual mode path comments by using relative paths
Jan 18, 2026
7bf7786
Merge branch 'main' into claude/virtual-bundler-tests
alii Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/bundler/css/css-modules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,15 @@ import { itBundled } from "../expectBundled";
describe("css", () => {
itBundled("css-module/GlobalPseudoFunction", {
files: {
"index.module.css": /* css */ `
"/index.module.css": /* css */ `
:global(.foo) {
color: red;
}
`,
},
outdir: "/out",
entryPoints: ["/index.module.css"],
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out/index.module.css").toEqualIgnoringWhitespace(`
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
/* index.module.css */
.foo {
color: red;
Expand Down
7 changes: 3 additions & 4 deletions test/bundler/css/is-selector-21169.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,15 @@ import { itBundled } from "../expectBundled";
describe("css", () => {
itBundled("css/is-selector", {
files: {
"index.css": /* css */ `
"/index.css": /* css */ `
.foo:is(input:checked) {
color: red;
}
`,
},
outdir: "/out",
entryPoints: ["/index.css"],
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out/index.css").toMatchInlineSnapshot(`
api.expectFile("/out.css").toMatchInlineSnapshot(`
"/* index.css */
.foo:-webkit-any(input:checked) {
color: red;
Expand Down
7 changes: 3 additions & 4 deletions test/bundler/css/view-transition-23600.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { itBundled } from "../expectBundled";
describe("css", () => {
itBundled("css/view-transition-class-selector-23600", {
files: {
"index.css": /* css */ `
"/index.css": /* css */ `
@keyframes slide-out {
from {
opacity: 1;
Expand Down Expand Up @@ -33,10 +33,9 @@ describe("css", () => {
}
`,
},
outdir: "/out",
entryPoints: ["/index.css"],
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out/index.css").toMatchInlineSnapshot(`
api.expectFile("/out.css").toMatchInlineSnapshot(`
"/* index.css */
@keyframes slide-out {
from {
Expand Down
3 changes: 2 additions & 1 deletion test/bundler/css/wpt/background-computed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import { itBundled } from "../../expectBundled";
const runTest = (property: string, input: string, expected: string) => {
const testTitle = `${property}: ${input}`;
itBundled(testTitle, {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
${property}: ${input}
}
`,
},
outfile: "out.css",
outfile: "/out.css",

onAfterBundle(api) {
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
Expand Down
3 changes: 2 additions & 1 deletion test/bundler/css/wpt/color-computed-rgb.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import { itBundled } from "../../expectBundled";
const runTest = (testTitle: string, input: string, expected: string) => {
testTitle = testTitle.length === 0 ? input : testTitle;
itBundled(testTitle, {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
color: ${input}
}
`,
},
outfile: "out.css",
outfile: "/out.css",

onAfterBundle(api) {
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
Expand Down
3 changes: 2 additions & 1 deletion test/bundler/css/wpt/color-computed.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ import { itBundled } from "../../expectBundled";

const runTest = (input: string, expected: string) => {
itBundled(input, {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
color: ${input}
}
`,
},
outfile: "out.css",
outfile: "/out.css",

onAfterBundle(api) {
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
Expand Down
29 changes: 28 additions & 1 deletion test/bundler/css/wpt/relative_color_out_of_gamut.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@ let i = 0;
const testname = () => `test-${i++}`;
describe("relative_color_out_of_gamut", () => {
itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
color: rgb(from color(display-p3 0 1 0) r g b / alpha);
}
`,
},
outfile: "out.css",
outfile: "/out.css",

onAfterBundle(api) {
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
Expand All @@ -25,6 +26,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -45,6 +47,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -65,6 +68,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -85,6 +89,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -105,6 +110,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -125,6 +131,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -145,6 +152,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -165,6 +173,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -185,6 +194,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -205,6 +215,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -225,6 +236,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -245,6 +257,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -265,6 +278,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -285,6 +299,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -305,6 +320,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -325,6 +341,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -345,6 +362,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -365,6 +383,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -385,6 +404,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -405,6 +425,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -425,6 +446,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -445,6 +467,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -465,6 +488,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -485,6 +509,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -505,6 +530,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand All @@ -525,6 +551,7 @@ h1 {
});

itBundled(testname(), {
virtual: true,
files: {
"/a.css": /* css */ `
h1 {
Expand Down
14 changes: 7 additions & 7 deletions test/bundler/esbuild/css.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ describe("bundler", () => {
color: black }
`,
},
outfile: "/out.js",
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out.js").toEqualIgnoringWhitespace(`
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
/* entry.css */
body {
color: #000;
Expand All @@ -31,9 +31,9 @@ describe("bundler", () => {
files: {
"/entry.css": /* css */ `\n`,
},
outfile: "/out.js",
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out.js").toEqualIgnoringWhitespace(`
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
/* entry.css */`);
},
});
Expand All @@ -48,12 +48,12 @@ describe("bundler", () => {
}
}`,
},
outfile: "/out.js",
outfile: "/out.css",
onAfterBundle(api) {
api.expectFile("/out.js").toEqualIgnoringWhitespace(`
api.expectFile("/out.css").toEqualIgnoringWhitespace(`
/* entry.css */
body {
&h1 {
& h1 {
color: #fff;
}
}
Expand Down
Loading