[dylan-conway]

What does this PR do?

Fixes a regression introduced in Bun v1.3.2 with #24283.

We are not able to skip sharp lifecycle scripts before v0.33.0 because previous versions did not use optional dependencies with prebuilds.

Fixes #24550
Fixes ENG-21519

How did you verify your code works?

Manually

[robobun]

^{Updated 10:48 AM PT - Nov 17th, 2025}

❌ @dylan-conway, your commit 8c80bcd has 5 failures in Build #31878 (All Failures):

• test/regression/issue/12042.test.ts - core dumped on 🐧 12 x64-asan
• test/js/bun/ffi/cc.test.ts - 1 failing on 🍎 13 aarch64
• test/v8/v8.test.ts - 1 failing on 🐧 12 x64-asan
• test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 13 aarch64
• test/js/third_party/pg-gateway/pglite.test.ts - pid 6322 error: addresssanitizer on 🐧 12 x64-asan

---

🧪   To try this PR locally:

bunx bun-pr 24726

That installs a local version of the PR into your bun-24726 executable, so you can run:

bun-24726 --bun

[coderabbitai]

Walkthrough

Function signatures in postinstall optimization were refactored to accept a struct containing package name hash, version, and string buffer instead of scalar arguments. This enables version-aware decision-making for lifecycle script handling and package optimization logic across the install system.

Changes

Cohort / File(s)	Summary
Call site updates for struct-based arguments src/install/PackageInstaller.zig, src/install/isolated_install/Installer.zig	Updated invocations of PostinstallOptimizer.get() to pass composite struct arguments containing name_hash, version, and version_buf instead of plain scalar name_hash parameters. Two call sites per file modified.
PostinstallOptimizer refactoring src/install/postinstall_optimizer.zig	Redefined get(), shouldIgnoreLifecycleScripts(), and fromDefault() to accept PkgInfo struct parameter instead of scalar name_hash. Introduced internal DefaultIgnore structure with minimum_version field. Added version-aware comparison logic for lifecycle script and default-binlink decisions. Updated internal lookups to operate on pkg_info.name_hash with version checks.

Pre-merge checks

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix #24550' directly references the linked issue but provides minimal detail about what is being fixed.	Consider expanding the title to briefly summarize the fix, e.g., 'fix: restore sharp lifecycle script skipping for versions before v0.33.0' to better convey the change.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The code changes address the regression by enabling version-aware lifecycle script skipping for sharp versions before v0.33.0 through struct-based parameter passing in postinstall optimizer.
Out of Scope Changes check	✅ Passed	All changes are focused on postinstall optimizer logic and call sites to support version-aware lifecycle script filtering, directly addressing the regression.
Description check	✅ Passed	The PR description follows the template with both required sections completed: 'What does this PR do?' explains the regression fix and references the linked issue; 'How did you verify your code works?' documents manual verification.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[linear]

ENG-21519 Fix `sharp` postinstall regression