Repository navigation
fix(install): bun pm ls with unresolved dependencies - #24541
Conversation
|
Updated 2:36 PM PT - Nov 9th, 2025
❌ @dylan-conway, your commit d85e2c1 has 1 failures in
🧪 To try this PR locally: bunx bun-pr 24541That installs a local version of the PR into your bun-24541 --bun |
WalkthroughThis PR addresses a segmentation fault in Changes
Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (4)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
🧰 Additional context used📓 Path-based instructions (5)**/*.zig📄 CodeRabbit inference engine (.cursor/rules/javascriptcore-class.mdc)
Files:
src/**/*.zig📄 CodeRabbit inference engine (.cursor/rules/building-bun.mdc)
Files:
test/**📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)
Files:
test/regression/issue/+([0-9])/**📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)
Files:
test/**/*.{js,ts}📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)
Files:
🧠 Learnings (27)📚 Learning: 2025-09-06T03:37:41.154ZApplied to files:
📚 Learning: 2025-08-30T00:13:36.815ZApplied to files:
📚 Learning: 2025-10-19T02:44:46.354ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-10-08T13:56:00.875ZApplied to files:
📚 Learning: 2025-09-12T18:16:50.754ZApplied to files:
📚 Learning: 2025-10-04T09:52:49.414ZApplied to files:
📚 Learning: 2025-10-19T02:52:37.412ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-09-08T00:41:12.052ZApplied to files:
📚 Learning: 2025-09-08T00:41:12.052ZApplied to files:
📚 Learning: 2025-10-26T01:32:04.844ZApplied to files:
📚 Learning: 2025-08-30T00:13:36.815ZApplied to files:
📚 Learning: 2025-08-30T00:13:36.815ZApplied to files:
📚 Learning: 2025-10-01T22:13:08.081ZApplied to files:
📚 Learning: 2025-08-31T09:08:12.104ZApplied to files:
📚 Learning: 2025-08-30T00:13:36.815ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-08-30T00:09:39.100ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-08-30T00:09:39.100ZApplied to files:
📚 Learning: 2025-10-08T13:48:02.430ZApplied to files:
📚 Learning: 2025-08-30T00:12:56.803ZApplied to files:
📚 Learning: 2025-11-06T00:58:23.965ZApplied to files:
📚 Learning: 2025-11-08T04:06:33.198ZApplied to files:
🧬 Code graph analysis (1)test/regression/issue/24502/bun-pm-ls-all-invalid-package-id.test.ts (1)
🔇 Additional comments (6)
Comment |
This reverts commit 6f9843e.
What does this PR do?
Fixes
bun pm ls --allcrash with unresolved optional peer dependencies.Fixes
bun pm lscrash with empty lockfiles.Fixes #24502
How did you verify your code works?
Added a test for both crashes